Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1647653007: Resolve signature from correct scope class (fix #25609). (Closed)

Created:
4 years, 10 months ago by regis
Modified:
4 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Resolve signature from correct scope class (fix #25609). Add regression test. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/220f8c57b32ba991dddcf9ac45b316f73b99daa2

Patch Set 1 #

Patch Set 2 : wip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -13 lines) Patch
M runtime/vm/class_finalizer.cc View 1 2 chunks +14 lines, -2 lines 0 comments Download
A + tests/language/regress_25609_lib1.dart View 1 chunk +4 lines, -3 lines 0 comments Download
A + tests/language/regress_25609_lib2.dart View 1 chunk +2 lines, -4 lines 0 comments Download
A + tests/language/regress_25609_test.dart View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
4 years, 10 months ago (2016-01-28 20:50:25 UTC) #2
siva
lgtm
4 years, 10 months ago (2016-01-28 21:11:57 UTC) #3
regis
4 years, 10 months ago (2016-01-28 21:29:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
220f8c57b32ba991dddcf9ac45b316f73b99daa2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698