Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1647653004: [x86] Remove obsolete and unused GetBuiltinFunction. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x86] Remove obsolete and unused GetBuiltinFunction. R=mstarzinger@chromium.org Committed: https://crrev.com/37ab5bfdff83c508afc19cd08f890f313fba41a7 Cr-Commit-Position: refs/heads/master@{#33577}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M src/ia32/macro-assembler-ia32.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-01-28 09:03:41 UTC) #1
Benedikt Meurer
Hey Michi, Dead code shall be dead. Please take a look. Thanks, Benedikt
4 years, 10 months ago (2016-01-28 09:04:28 UTC) #2
Michael Starzinger
Instant-LGTM. Just add water. :)
4 years, 10 months ago (2016-01-28 09:07:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647653004/1
4 years, 10 months ago (2016-01-28 09:07:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 09:35:03 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 09:35:39 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/37ab5bfdff83c508afc19cd08f890f313fba41a7
Cr-Commit-Position: refs/heads/master@{#33577}

Powered by Google App Engine
This is Rietveld 408576698