Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1647583002: Fixed a bug in DesktopMediaID class (Closed)

Created:
4 years, 11 months ago by GeorgeZ
Modified:
4 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed an apparent bug introduced in https://codereview.chromium.org/1503563004/ This is a bug in DesktopMediaID class's overloaded operator <. "other." is missed in front of web_content_id BUG=557222 Committed: https://crrev.com/11f2c00dc0e05b7208a3d1730539866e30e289b9 Cr-Commit-Position: refs/heads/master@{#372353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/browser/desktop_media_id.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
GeorgeZ
Hi Jochen, Would you please have a review of this simple CL. Thanks, George
4 years, 11 months ago (2016-01-27 20:31:23 UTC) #3
jochen (gone - plz use gerrit)
can you update the CL description to have the one-line summary as the first line? ...
4 years, 10 months ago (2016-01-28 12:14:21 UTC) #4
GeorgeZ
On 2016/01/28 12:14:21, jochen wrote: > can you update the CL description to have the ...
4 years, 10 months ago (2016-01-28 15:34:13 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 10 months ago (2016-01-29 09:17:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647583002/1
4 years, 10 months ago (2016-01-29 16:00:36 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 16:13:10 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 16:14:07 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11f2c00dc0e05b7208a3d1730539866e30e289b9
Cr-Commit-Position: refs/heads/master@{#372353}

Powered by Google App Engine
This is Rietveld 408576698