Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1647573002: cc cleanup: simplify mask_uv_scale and MaskUVRect(). (Closed)

Created:
4 years, 11 months ago by Stephen White
Modified:
4 years, 11 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc cleanup: simplify mask_uv_scale and MaskUVRect(). RenderPassDrawQuad::MaskUVRect() computes the UV rect by scaling the quad->rect() by mask_uv_scale, then dividing by quad->rect size. However, RenderSurfaceImpl::AppendQuads() computes the mask UV scale as quad->rect() size / mask size. So let's just take the quad->rect() size out of mask_uv_scale in the first place, so we don't have to divide it back out in MaskUVRect(). BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/dfcb362e77eff630f887efd4491814f076e3b8a2 Cr-Commit-Position: refs/heads/master@{#371879}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -23 lines) Patch
M cc/layers/render_surface_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/layers/render_surface_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/renderer_pixeltest.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M cc/quads/render_pass_draw_quad.cc View 1 chunk +1 line, -5 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647573002/1
4 years, 11 months ago (2016-01-27 19:26:40 UTC) #3
Stephen White
enne@: PTAL. Thanks!
4 years, 11 months ago (2016-01-27 19:27:04 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-27 20:43:26 UTC) #8
enne (OOO)
lgtm
4 years, 11 months ago (2016-01-27 21:35:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647573002/1
4 years, 11 months ago (2016-01-27 21:40:17 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 21:48:08 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 21:49:23 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfcb362e77eff630f887efd4491814f076e3b8a2
Cr-Commit-Position: refs/heads/master@{#371879}

Powered by Google App Engine
This is Rietveld 408576698