Add the ability to resynthesize class members from summaries.

Add the ability to resynthesize class members from summaries.

This is needed to support type inference, since an inferred type may
point to a parameter of a class member.

I believe it will also be useful for reserializing constant ASTs.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/d24548220a96fe30b531961f933e024a13c28a5f

[Paul Berry, 2016-01-27 19:17:29]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2016-01-27 19:34:54]

LGTM, but I have couple questions for tests.

https://codereview.chromium.org/1647553002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_test.dart (right):

https://codereview.chromium.org/1647553002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_test.dart:516: * Convert the given
[source] into an element model and then serialize it
I don't quite understand this comment or the code.
It seems that we don't convert the source into an element model, but we get the
original library as parameter.

https://codereview.chromium.org/1647553002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_test.dart:1816: encodeLibrary(source,
originalLibrary);
Do we expect passing other Source than library.source into "encodeLibrary"?

[Paul Berry, 2016-01-27 20:34:41]

https://codereview.chromium.org/1647553002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_test.dart (right):

https://codereview.chromium.org/1647553002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_test.dart:516: * Convert the given
[source] into an element model and then serialize it
On 2016/01/27 19:34:54, scheglov wrote:
> I don't quite understand this comment or the code.
> It seems that we don't convert the source into an element model, but we get
the
> original library as parameter.

You're right, this doesn't make sense.  I've rewritten the code to just use
original.source, and clarified the comment.

https://codereview.chromium.org/1647553002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_test.dart:1816: encodeLibrary(source,
originalLibrary);
On 2016/01/27 19:34:54, scheglov wrote:
> Do we expect passing other Source than library.source into "encodeLibrary"?

Acknowledged.

[Paul Berry, 2016-01-27 20:35:15]

Description was changed from

==========
Add the ability to resynthesize class members from summaries.

This is needed to support type inference, since an inferred type may
point to a parameter of a class member.

I believe it will also be useful for reserializing constant ASTs.
==========

to

==========
Add the ability to resynthesize class members from summaries.

This is needed to support type inference, since an inferred type may
point to a parameter of a class member.

I believe it will also be useful for reserializing constant ASTs.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d24548220a96fe30b531961f933e024a13c28a5f
==========

[Paul Berry, 2016-01-27 20:35:17]

Committed patchset #2 (id:20001) manually as
d24548220a96fe30b531961f933e024a13c28a5f (presubmit successful).