Issue 164753008: Views Omnibox: Only select all on update with previous selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164753008: Views Omnibox: Only select all on update with previous selection. (Closed)

Created:
6 years, 10 months ago by msw

Modified:
6 years, 10 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, tfarina, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Views Omnibox: Only select all on update with previous selection. BUG=343852 TEST=With a clear selection clipboard on Linux Aura; type "chrome://apps"+[ENTER]; open a new tab and middle click in the empty omnibox; no text should be pasted. No selection/update or other Omnibox behavior regressions. R=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251516

Patch Set 1 : Only select all on omnibox update with previous selection. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/browser/ui/views/omnibox/omnibox_view_views.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/164753008/140001

6 years, 10 months ago (2014-02-14 23:23:19 UTC) #4

Message was sent while issue was closed.

Change committed as 251516

Expand Messages | Collapse Messages