Start of Chrome-side plumbing for ServiceWorker fetch

Start of Chrome-side plumbing for ServiceWorker fetch

Now ServiceWorkerScriptContext::OnFetchEvent provides a dummy response
to the callback.

BUG=342301
TEST=content_browsertests:ServiceWorkerVersionBrowserTest.Fetch

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252249

[falken, 2014-02-14 08:31:34]

This CL is still WIP but I want to share my status and possibly get early
feedback.

I plan to plumb the dummy response all the way to the browsertest before trying
to commit this. So, I need to change DispatchFetchEvent to take a callback that
accepts the  ServiceWorkerEventResponse and have the testing code use that.

[kinuko, 2014-02-14 08:56:23]

Yup, this looks to be in the same direction as I was thinking.

https://codereview.chromium.org/164753006/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_version.cc (right):

https://codereview.chromium.org/164753006/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_version.cc:213:
SendMessageAndRegisterCallback(
SendMessageAndRegisterCallback internally checks if the worker's running and
will (try to) start it if it's not, so no worries about it (at least in this
layer)

https://codereview.chromium.org/164753006/diff/1/content/common/service_worke...
File content/common/service_worker/service_worker_types.h (right):

https://codereview.chromium.org/164753006/diff/1/content/common/service_worke...
content/common/service_worker/service_worker_types.h:52: std::string statusText;
nit: we're in chrome, please use snake_case rather than camelCase :)

[nhiroki, 2014-02-14 09:03:21]

https://codereview.chromium.org/164753006/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_browsertest.cc (right):

https://codereview.chromium.org/164753006/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_browsertest.cc:234:
ServiceWorkerStatusCode* result) {
indent-nit.

https://codereview.chromium.org/164753006/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_browsertest.cc:241:
ServiceWorkerStatusCode* result) {
ditto.

https://codereview.chromium.org/164753006/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_version.h (right):

https://codereview.chromium.org/164753006/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_version.h:126: // TODO(kinuko):
Make this take callback as well.
Can you remove this TODO comment?

https://codereview.chromium.org/164753006/diff/1/content/renderer/service_wor...
File content/renderer/service_worker/service_worker_script_context.cc (right):

https://codereview.chromium.org/164753006/diff/1/content/renderer/service_wor...
content/renderer/service_worker/service_worker_script_context.cc:7: #include
"base/debug/stack_trace.h"
It looks like this is not used for now. Are you planning to use this in the
following changes?

[kinuko, 2014-02-14 09:19:13]

https://codereview.chromium.org/164753006/diff/1/content/renderer/service_wor...
File content/renderer/service_worker/service_worker_script_context.cc (right):

https://codereview.chromium.org/164753006/diff/1/content/renderer/service_wor...
content/renderer/service_worker/service_worker_script_context.cc:7: #include
"base/debug/stack_trace.h"
On 2014/02/14 09:03:21, nhiroki wrote:
> It looks like this is not used for now. Are you planning to use this in the
> following changes?

This is WIP patch, I believe it's for his local debugging...

[nhiroki, 2014-02-14 09:41:49]

https://codereview.chromium.org/164753006/diff/1/content/renderer/service_wor...
File content/renderer/service_worker/service_worker_script_context.cc (right):

https://codereview.chromium.org/164753006/diff/1/content/renderer/service_wor...
content/renderer/service_worker/service_worker_script_context.cc:7: #include
"base/debug/stack_trace.h"
On 2014/02/14 09:19:13, kinuko wrote:
> On 2014/02/14 09:03:21, nhiroki wrote:
> > It looks like this is not used for now. Are you planning to use this in the
> > following changes?
> 
> This is WIP patch, I believe it's for his local debugging...

Ah, that make sense.

[falken, 2014-02-19 05:32:19]

Thanks for the comments! Please see the new patch (no longer "WIP").

https://codereview.chromium.org/164753006/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_browsertest.cc (right):

https://codereview.chromium.org/164753006/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_browsertest.cc:234:
ServiceWorkerStatusCode* result) {
On 2014/02/14 09:03:21, nhiroki wrote:
> indent-nit.

Done.

https://codereview.chromium.org/164753006/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_browsertest.cc:241:
ServiceWorkerStatusCode* result) {
On 2014/02/14 09:03:21, nhiroki wrote:
> ditto.

Done.

https://codereview.chromium.org/164753006/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_version.cc (right):

https://codereview.chromium.org/164753006/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_version.cc:213:
SendMessageAndRegisterCallback(
On 2014/02/14 08:56:24, kinuko wrote:
> SendMessageAndRegisterCallback internally checks if the worker's running and
> will (try to) start it if it's not, so no worries about it (at least in this
> layer)

OK, I see. TODO removed.

https://codereview.chromium.org/164753006/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_version.h (right):

https://codereview.chromium.org/164753006/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_version.h:126: // TODO(kinuko):
Make this take callback as well.
On 2014/02/14 09:03:21, nhiroki wrote:
> Can you remove this TODO comment?

Done.

https://codereview.chromium.org/164753006/diff/1/content/common/service_worke...
File content/common/service_worker/service_worker_types.h (right):

https://codereview.chromium.org/164753006/diff/1/content/common/service_worke...
content/common/service_worker/service_worker_types.h:52: std::string statusText;
On 2014/02/14 08:56:24, kinuko wrote:
> nit: we're in chrome, please use snake_case rather than camelCase :)

Done.

https://codereview.chromium.org/164753006/diff/1/content/renderer/service_wor...
File content/renderer/service_worker/service_worker_script_context.cc (right):

https://codereview.chromium.org/164753006/diff/1/content/renderer/service_wor...
content/renderer/service_worker/service_worker_script_context.cc:7: #include
"base/debug/stack_trace.h"
On 2014/02/14 09:41:50, nhiroki wrote:
> On 2014/02/14 09:19:13, kinuko wrote:
> > On 2014/02/14 09:03:21, nhiroki wrote:
> > > It looks like this is not used for now. Are you planning to use this in
the
> > > following changes?
> > 
> > This is WIP patch, I believe it's for his local debugging...
> 
> Ah, that make sense.

Right it was just for debugging. Removed.

[kinuko, 2014-02-19 07:17:59]

lgtm

https://codereview.chromium.org/164753006/diff/190001/content/browser/service...
File content/browser/service_worker/service_worker_browsertest.cc (right):

https://codereview.chromium.org/164753006/diff/190001/content/browser/service...
content/browser/service_worker/service_worker_browsertest.cc:69: 
nit: extra empty line

https://codereview.chromium.org/164753006/diff/190001/content/common/service_...
File content/common/service_worker/service_worker_messages.h (right):

https://codereview.chromium.org/164753006/diff/190001/content/common/service_...
content/common/service_worker/service_worker_messages.h:34:
IPC_STRUCT_TRAITS_END()
(I assume we'll be fixing up these Request & Response structs when more code
evolve)

[falken, 2014-02-19 07:30:00]

Thanks!

https://codereview.chromium.org/164753006/diff/190001/content/browser/service...
File content/browser/service_worker/service_worker_browsertest.cc (right):

https://codereview.chromium.org/164753006/diff/190001/content/browser/service...
content/browser/service_worker/service_worker_browsertest.cc:69: 
On 2014/02/19 07:18:00, kinuko wrote:
> nit: extra empty line

Done.

[falken, 2014-02-19 07:30:14]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2014-02-19 07:30:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/falken@chromium.org/164753006/230001

[commit-bot: I haz the power, 2014-02-19 07:33:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-19 07:33:46]

Try jobs failed on following builders: mac_chromium_rel

[falken, 2014-02-19 07:39:09]

tsepez@: could you do an OWNER review for
content/common/service_worker_messages.h please?

[nhiroki, 2014-02-19 07:49:34]

lgtm

[Tom Sepez, 2014-02-19 20:21:56]

Messages LGTM.

[falken, 2014-02-20 01:35:59]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2014-02-20 01:40:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/falken@chromium.org/164753006/230001

[commit-bot: I haz the power, 2014-02-20 02:02:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-20 02:02:15]

Try jobs failed on following builders: linux_chromium_rel, mac_chromium_rel

[falken, 2014-02-20 03:01:27]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2014-02-20 05:10:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/falken@chromium.org/164753006/230001

[commit-bot: I haz the power, 2014-02-20 09:06:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/falken@chromium.org/164753006/230001

[commit-bot: I haz the power, 2014-02-20 12:28:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/falken@chromium.org/164753006/230001

[commit-bot: I haz the power, 2014-02-20 15:59:26]

Change committed as 252249