Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 164753003: Potential fix for array bounds warning. (Closed)

Created:
6 years, 10 months ago by jvanverth1
Modified:
6 years, 10 months ago
Reviewers:
caryclark
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Potential fix for array bounds warning. BUG=skia:2123 Committed: http://code.google.com/p/skia/source/detail?r=13531

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M src/pathops/SkDCubicToQuads.cpp View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jvanverth1
Took a stab at this, hope you don't mind. It doesn't fix all the warnings ...
6 years, 10 months ago (2014-02-13 22:59:51 UTC) #1
caryclark
This looks fine (although the trybot failed catastrophically!) lgtm
6 years, 10 months ago (2014-02-21 13:31:08 UTC) #2
jvanverth1
The CQ bit was checked by jvanverth@google.com
6 years, 10 months ago (2014-02-21 14:09:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/164753003/1
6 years, 10 months ago (2014-02-21 14:10:02 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 15:27:50 UTC) #5
Message was sent while issue was closed. 
Change committed as 13531

Powered by Google App Engine
This is Rietveld 408576698