Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 1647493002: Only add -isystem for libc++ for C++ files, not C files. (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only add -isystem for libc++ for C++ files, not C files. Seems cleaner. libc++ recently added a few headers that shadow C headers, and shouldn't pick those up when building C files. No intended behavior change. BUG=none Committed: https://crrev.com/190db871a42f413b37dc683cb0959808671082d7 Cr-Commit-Position: refs/heads/master@{#371949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M build/config/android/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Nico
4 years, 11 months ago (2016-01-27 21:02:32 UTC) #2
brettw
lgtm
4 years, 11 months ago (2016-01-27 23:21:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647493002/1
4 years, 11 months ago (2016-01-28 00:57:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-28 01:06:45 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 01:16:35 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/190db871a42f413b37dc683cb0959808671082d7
Cr-Commit-Position: refs/heads/master@{#371949}

Powered by Google App Engine
This is Rietveld 408576698