third_party/WebKit/Source/web/mac/WebSubstringUtil.mm - Issue 1647483003: Introduce TextBuffer as Output Type of copyTextTo() for Text Iterators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

Issue 1647483003: Introduce TextBuffer as Output Type of copyTextTo() for Text Iterators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/iterators/TextBuffer.cpp ('K') | « third_party/WebKit/Source/core/editing/iterators/WordAwareIterator.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

diff --git a/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm b/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

index 350e9cb072ff92136e107450e6ab66a12decc15d..6014041abad066e39b1bb1e0156555e38ad0c86e 100644

--- a/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

+++ b/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

@@ -96,7 +96,7 @@ static NSAttributedString* attributedSubstringFromRange(const EphemeralRange& ra

else

[attrs removeObjectForKey:NSBackgroundColorAttributeName];

- Vector<UChar> characters;

+ ForwardsTextBuffer characters;

it.copyTextTo(characters);

NSString* substring =

[[[NSString alloc] initWithCharacters:characters.data()