Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 1647473002: [Line Layout API] Add LineLayoutItem::resolveColor() (Closed)

Created:
4 years, 10 months ago by pilgrim_google
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1, dgrogan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Line Layout API] Add LineLayoutItem::resolveColor() This addition to the line layout API has cascading effects (all good): 1. Allows us to convert several methods in TextPainter to take a LineLayoutItem instead of LayoutText 2. Removes several instances of using the LineLayoutAPIShim just to call the resolveColor method 3. Converts a (required) reference of InlineBox::layoutObject() to lineLayoutItem() 4. Lets us convert TextPainterTest entirely to the line layout API There are no functional changes. BUG=499321 Committed: https://crrev.com/727bd37e175b238e38463e2d05e58f542a1427ac Cr-Commit-Position: refs/heads/master@{#371932}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -23 lines) Patch
M third_party/WebKit/Source/core/layout/api/LineLayoutItem.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/EllipsisBoxPainter.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TextPainter.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TextPainter.cpp View 4 chunks +10 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TextPainterTest.cpp View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pilgrim_google
4 years, 10 months ago (2016-01-27 16:56:01 UTC) #2
eae
LGTM
4 years, 10 months ago (2016-01-27 21:32:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647473002/1
4 years, 10 months ago (2016-01-27 22:37:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 00:25:46 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 00:28:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/727bd37e175b238e38463e2d05e58f542a1427ac
Cr-Commit-Position: refs/heads/master@{#371932}

Powered by Google App Engine
This is Rietveld 408576698