third_party/protobuf/src/google/protobuf/generated_message_util.cc - Issue 164743002: Replace kEmptyString with OnceInit initialized string*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/protobuf/src/google/protobuf/generated_message_util.cc

Issue 164743002: Replace kEmptyString with OnceInit initialized string* (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/protobuf/src/google/protobuf/generated_message_util.cc

diff --git a/third_party/protobuf/src/google/protobuf/generated_message_util.cc b/third_party/protobuf/src/google/protobuf/generated_message_util.cc

index ac32150146f21c1d122dcec7be22ee79a6ad7c25..794be3571053165bf5b56e75a3b5e8afd6d9edf7 100644

--- a/third_party/protobuf/src/google/protobuf/generated_message_util.cc

+++ b/third_party/protobuf/src/google/protobuf/generated_message_util.cc

@@ -47,7 +47,12 @@ double NaN() {

return std::numeric_limits<double>::quiet_NaN();

}

-const ::std::string kEmptyString;

+const ::std::string* empty_string_;

+ProtobufOnceType empty_string_once_init_;

+void InitEmptyString() {

+ empty_string_ = new std::string();

} // namespace internal

} // namespace protobuf