third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_string_field.cc - Issue 164743002: Replace kEmptyString with OnceInit initialized string*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_string_field.cc

Issue 164743002: Replace kEmptyString with OnceInit initialized string* (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_string_field.cc

diff --git a/third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_string_field.cc b/third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_string_field.cc

index 9c0911ac9690f102b69c56d76804aed3f4ed0480..0b58b981ec5b57f72e9052d7d310d6b61ce534bd 100644

--- a/third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_string_field.cc

+++ b/third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_string_field.cc

@@ -53,7 +53,7 @@ void SetStringVariables(const FieldDescriptor* descriptor,

(*variables)["default_length"] =

SimpleItoa(descriptor->default_value_string().length());

(*variables)["default_variable"] = descriptor->default_value_string().empty()

- ? "&::google::protobuf::internal::kEmptyString"

+ ? "&::google::protobuf::internal::GetEmptyString()"

: "_default_" + FieldName(descriptor) + "_";

(*variables)["pointer_type"] =

descriptor->type() == FieldDescriptor::TYPE_BYTES ? "void" : "char";

« no previous file with comments | « third_party/protobuf/README.chromium ('k') | third_party/protobuf/src/google/protobuf/compiler/plugin.pb.h » ('j') | no next file with comments »