components/cronet/tools/extract_from_jars.py - Issue 1647353002: Use gn_helpers to [se]serialize GN lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/tools/extract_from_jars.py

Issue 1647353002: Use gn_helpers to [se]serialize GN lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@python_impl

Patch Set: more Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/cronet/tools/extract_from_jars.py

diff --git a/components/cronet/tools/extract_from_jars.py b/components/cronet/tools/extract_from_jars.py

index 9e573987ec2b99918f7d5e1bc8670333fd2c2880..ee32b940fec703af7aba9b9ef26f1cd8d739d184 100755

--- a/components/cronet/tools/extract_from_jars.py

+++ b/components/cronet/tools/extract_from_jars.py

@@ -22,7 +22,7 @@ def ExtractJars(options):

jar_cwd = options.classes_dir

build_utils.DeleteDirectory(jar_cwd)

build_utils.MakeDirectory(jar_cwd)

- for jar in build_utils.ParseGypList(options.jars):

+ for jar in build_utils.ParseGnList(options.jars):

jar_path = os.path.abspath(jar)

jar_cmd = ['jar', 'xf', jar_path]

build_utils.CheckOutput(jar_cmd, cwd=jar_cwd)

« no previous file with comments | « build/config/android/rules.gni ('k') | components/cronet/tools/jar_src.py » ('j') | no next file with comments »