build/android/incremental_install/create_install_script.py - Issue 1647353002: Use gn_helpers to [se]serialize GN lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/incremental_install/create_install_script.py

Issue 1647353002: Use gn_helpers to [se]serialize GN lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@python_impl

Patch Set: more Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/incremental_install/create_install_script.py

diff --git a/build/android/incremental_install/create_install_script.py b/build/android/incremental_install/create_install_script.py

index 5be4fe43700a18909d18db75b86dd3fde04d5510..d8afc0d54b30302c1f9953830b507653112b2d02 100755

--- a/build/android/incremental_install/create_install_script.py

+++ b/build/android/incremental_install/create_install_script.py

@@ -116,10 +116,10 @@ def _ParseArgs(args):

help='Prints this message and exits.')

options = parser.parse_args(args)

- options.dex_files += build_utils.ParseGypList(options.dex_file_list)

+ options.dex_files += build_utils.ParseGnList(options.dex_file_list)

all_libs = []

for gyp_list in options.native_libs:

- all_libs.extend(build_utils.ParseGypList(gyp_list))

+ all_libs.extend(build_utils.ParseGnList(gyp_list))

options.native_libs = all_libs

return options

« no previous file with comments | « build/android/gyp/write_ordered_libraries.py ('k') | build/config/android/rules.gni » ('j') | no next file with comments »