build/android/gyp/write_ordered_libraries.py - Issue 1647353002: Use gn_helpers to [se]serialize GN lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/write_ordered_libraries.py

Issue 1647353002: Use gn_helpers to [se]serialize GN lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@python_impl

Patch Set: more Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/gyp/write_ordered_libraries.py

diff --git a/build/android/gyp/write_ordered_libraries.py b/build/android/gyp/write_ordered_libraries.py

index 67662e8d1c50f07d9fc5129c804dcd51105f1cf0..fd25e8e65219b0e28b3562032faca0824f2f8e0a 100755

--- a/build/android/gyp/write_ordered_libraries.py

+++ b/build/android/gyp/write_ordered_libraries.py

@@ -111,7 +111,7 @@ def main():

SetReadelfPath(options.readelf)

SetLibraryDirs(options.libraries_dir.split(','))

- libraries = build_utils.ParseGypList(options.input_libraries)

+ libraries = build_utils.ParseGnList(options.input_libraries)

if len(libraries):

libraries = GetSortedTransitiveDependenciesForBinaries(libraries)