build/android/gyp/lint.py - Issue 1647353002: Use gn_helpers to [se]serialize GN lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/lint.py

Issue 1647353002: Use gn_helpers to [se]serialize GN lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@python_impl

Patch Set: more Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/gyp/lint.py

diff --git a/build/android/gyp/lint.py b/build/android/gyp/lint.py

index bc09692a03c0833f82f7a4c981028ee05bc19e16..a13a675341ad85f8c9aa783f773cdbd30802f9d0 100755

--- a/build/android/gyp/lint.py

+++ b/build/android/gyp/lint.py

@@ -290,7 +290,7 @@ def main():

if args.enable:

sources = []

if args.src_dirs:

- src_dirs = build_utils.ParseGypList(args.src_dirs)

+ src_dirs = build_utils.ParseGnList(args.src_dirs)

sources = build_utils.FindInDirectories(src_dirs, '*.java')

elif args.java_sources_file:

sources.extend(build_utils.ReadSourcesList(args.java_sources_file))

@@ -314,7 +314,7 @@ def main():

input_paths.extend(sources)

classpath = []

for gyp_list in args.classpath:

- classpath.extend(build_utils.ParseGypList(gyp_list))

+ classpath.extend(build_utils.ParseGnList(gyp_list))

input_paths.extend(classpath)

resource_sources = []

@@ -323,7 +323,7 @@ def main():

resource_sources += [ args.resource_dir ]

for gyp_list in args.resource_sources:

- resource_sources += build_utils.ParseGypList(gyp_list)

+ resource_sources += build_utils.ParseGnList(gyp_list)

for resource_source in resource_sources:

if os.path.isdir(resource_source):

« no previous file with comments | « build/android/gyp/jinja_template.py ('k') | build/android/gyp/locale_pak_resources.py » ('j') | no next file with comments »