Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2798)

Unified Diff: build/android/gyp/insert_chromium_version.py

Issue 1647353002: Use gn_helpers to [se]serialize GN lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@python_impl
Patch Set: more Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/gyp/generate_resource_rewriter.py ('k') | build/android/gyp/jar.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/insert_chromium_version.py
diff --git a/build/android/gyp/insert_chromium_version.py b/build/android/gyp/insert_chromium_version.py
deleted file mode 100755
index 171f9d41b8d1d70f281b6c5fb6a65c2d347e25fb..0000000000000000000000000000000000000000
--- a/build/android/gyp/insert_chromium_version.py
+++ /dev/null
@@ -1,66 +0,0 @@
-#!/usr/bin/env python
-#
-# Copyright 2014 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-"""Insert a version string into a library as a section '.chromium.version'.
-"""
-
-import optparse
-import os
-import sys
-import tempfile
-
-from util import build_utils
-
-def InsertChromiumVersion(android_objcopy,
- library_path,
- version_string):
- # Remove existing .chromium.version section from .so
- objcopy_command = [android_objcopy,
- '--remove-section=.chromium.version',
- library_path]
- build_utils.CheckOutput(objcopy_command)
-
- # Add a .chromium.version section.
- with tempfile.NamedTemporaryFile() as stream:
- stream.write(version_string)
- stream.flush()
- objcopy_command = [android_objcopy,
- '--add-section', '.chromium.version=%s' % stream.name,
- library_path]
- build_utils.CheckOutput(objcopy_command)
-
-def main(args):
- args = build_utils.ExpandFileArgs(args)
- parser = optparse.OptionParser()
-
- parser.add_option('--android-objcopy',
- help='Path to the toolchain\'s objcopy binary')
- parser.add_option('--stripped-libraries-dir',
- help='Directory of native libraries')
- parser.add_option('--libraries',
- help='List of libraries')
- parser.add_option('--version-string',
- help='Version string to be inserted')
- parser.add_option('--stamp', help='Path to touch on success')
-
- options, _ = parser.parse_args(args)
- libraries = build_utils.ParseGypList(options.libraries)
-
- for library in libraries:
- library_path = os.path.join(options.stripped_libraries_dir, library)
-
- InsertChromiumVersion(options.android_objcopy,
- library_path,
- options.version_string)
-
- if options.stamp:
- build_utils.Touch(options.stamp)
-
- return 0
-
-
-if __name__ == '__main__':
- sys.exit(main(sys.argv[1:]))
« no previous file with comments | « build/android/gyp/generate_resource_rewriter.py ('k') | build/android/gyp/jar.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698