Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: build/android/findbugs_diff.py

Issue 1647353002: Use gn_helpers to [se]serialize GN lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@python_impl
Patch Set: more Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/android/gyp/aidl.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 3 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 """Runs findbugs, and returns an error code if there are new warnings. 7 """Runs findbugs, and returns an error code if there are new warnings.
8 8
9 Other options 9 Other options
10 --only-analyze used to only analyze the class you are interested. 10 --only-analyze used to only analyze the class you are interested.
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 75
76 args = parser.parse_args(build_utils.ExpandFileArgs(sys.argv[1:])) 76 args = parser.parse_args(build_utils.ExpandFileArgs(sys.argv[1:]))
77 77
78 run_tests_helper.SetLogLevel(args.verbose) 78 run_tests_helper.SetLogLevel(args.verbose)
79 79
80 devil_chromium.Initialize() 80 devil_chromium.Initialize()
81 81
82 if args.auxclasspath: 82 if args.auxclasspath:
83 args.auxclasspath = args.auxclasspath.split(':') 83 args.auxclasspath = args.auxclasspath.split(':')
84 elif args.auxclasspath_gyp: 84 elif args.auxclasspath_gyp:
85 args.auxclasspath = build_utils.ParseGypList(args.auxclasspath_gyp) 85 args.auxclasspath = build_utils.ParseGnList(args.auxclasspath_gyp)
86 86
87 if args.base_dir: 87 if args.base_dir:
88 if not args.exclude: 88 if not args.exclude:
89 args.exclude = os.path.join(args.base_dir, 'findbugs_exclude.xml') 89 args.exclude = os.path.join(args.base_dir, 'findbugs_exclude.xml')
90 90
91 findbugs_command, findbugs_warnings = findbugs.Run( 91 findbugs_command, findbugs_warnings = findbugs.Run(
92 args.exclude, args.only_analyze, args.auxclasspath, 92 args.exclude, args.only_analyze, args.auxclasspath,
93 args.output_file, args.findbug_args, args.jar_paths) 93 args.output_file, args.findbug_args, args.jar_paths)
94 94
95 if findbugs_warnings: 95 if findbugs_warnings:
(...skipping 15 matching lines...) Expand all
111 + args.jar_paths) 111 + args.jar_paths)
112 if args.stamp: 112 if args.stamp:
113 build_utils.Touch(args.stamp) 113 build_utils.Touch(args.stamp)
114 114
115 return len(findbugs_warnings) 115 return len(findbugs_warnings)
116 116
117 117
118 if __name__ == '__main__': 118 if __name__ == '__main__':
119 sys.exit(main()) 119 sys.exit(main())
120 120
OLDNEW
« no previous file with comments | « no previous file | build/android/gyp/aidl.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698