Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1519)

Unified Diff: content/browser/service_worker/service_worker_version_unittest.cc

Issue 1647323002: Move activate event dispatching out of ServiceWorkerVersion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor-install-event
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version_unittest.cc
diff --git a/content/browser/service_worker/service_worker_version_unittest.cc b/content/browser/service_worker/service_worker_version_unittest.cc
index 6fa7c694efed863cbdea5faa8192f6b75280de70..250946fcbe81d7028bdd159bffabf9363c02adfc 100644
--- a/content/browser/service_worker/service_worker_version_unittest.cc
+++ b/content/browser/service_worker/service_worker_version_unittest.cc
@@ -582,8 +582,7 @@ TEST_F(ServiceWorkerVersionTest, ActivateAndWaitCompletion) {
version_->SetStatus(ServiceWorkerVersion::ACTIVATING);
// Dispatch an activate event.
- ServiceWorkerStatusCode status = SERVICE_WORKER_ERROR_FAILED;
- version_->DispatchActivateEvent(CreateReceiverOnCurrentThread(&status));
+ SimulateDispatchEvent(ServiceWorkerMetrics::EventType::ACTIVATE);
// Wait for the completion.
bool status_change_called = false;
@@ -593,7 +592,6 @@ TEST_F(ServiceWorkerVersionTest, ActivateAndWaitCompletion) {
base::RunLoop().RunUntilIdle();
// Version's status must not have changed during activation.
- EXPECT_EQ(SERVICE_WORKER_OK, status);
EXPECT_FALSE(status_change_called);
EXPECT_EQ(ServiceWorkerVersion::ACTIVATING, version_->status());
}
@@ -1023,10 +1021,8 @@ TEST_F(ServiceWorkerFailToStartTest, RendererCrash) {
TEST_F(ServiceWorkerFailToStartTest, Timeout) {
ServiceWorkerStatusCode status = SERVICE_WORKER_ERROR_NETWORK; // dummy value
- // We could just call StartWorker but make it interesting and test
- // starting the worker as part of dispatching an event.
- version_->SetStatus(ServiceWorkerVersion::ACTIVATING);
- version_->DispatchActivateEvent(CreateReceiverOnCurrentThread(&status));
+ // Start starting the worker.
+ version_->StartWorker(CreateReceiverOnCurrentThread(&status));
base::RunLoop().RunUntilIdle();
// Callback has not completed yet.

Powered by Google App Engine
This is Rietveld 408576698