Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: content/browser/service_worker/service_worker_registration.h

Issue 1647323002: Move activate event dispatching out of ServiceWorkerVersion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor-install-event
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_registration.h
diff --git a/content/browser/service_worker/service_worker_registration.h b/content/browser/service_worker/service_worker_registration.h
index dab20434ce5af94c7a49c39be2b742ce163d7cec..6f0ebe8eea7d9f21ea6352c462d99956f85cfb85 100644
--- a/content/browser/service_worker/service_worker_registration.h
+++ b/content/browser/service_worker/service_worker_registration.h
@@ -157,8 +157,10 @@ class CONTENT_EXPORT ServiceWorkerRegistration
// This method corresponds to the [[Activate]] algorithm.
void ActivateWaitingVersion();
+ void DispatchActivateEvent(
+ const scoped_refptr<ServiceWorkerVersion>& activating_version);
void OnActivateEventFinished(
- ServiceWorkerVersion* activating_version,
+ const scoped_refptr<ServiceWorkerVersion>& activating_version,
ServiceWorkerStatusCode status);
void OnDeleteFinished(ServiceWorkerStatusCode status);

Powered by Google App Engine
This is Rietveld 408576698