Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Side by Side Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 1647323002: Move activate event dispatching out of ServiceWorkerVersion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor-install-event
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 617 matching lines...) Expand 10 before | Expand all | Expand 10 after
628 wrapper()->context()->storage()->StoreRegistration( 628 wrapper()->context()->storage()->StoreRegistration(
629 registration_.get(), version, 629 registration_.get(), version,
630 CreateReceiver(BrowserThread::UI, done, result)); 630 CreateReceiver(BrowserThread::UI, done, result));
631 } 631 }
632 632
633 void ActivateOnIOThread(const base::Closure& done, 633 void ActivateOnIOThread(const base::Closure& done,
634 ServiceWorkerStatusCode* result) { 634 ServiceWorkerStatusCode* result) {
635 ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::IO)); 635 ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::IO));
636 version_->SetStatus(ServiceWorkerVersion::ACTIVATING); 636 version_->SetStatus(ServiceWorkerVersion::ACTIVATING);
637 registration_->SetActiveVersion(version_.get()); 637 registration_->SetActiveVersion(version_.get());
638 version_->DispatchActivateEvent( 638 version_->RunAfterStartWorker(
639 base::Bind(&self::DispatchActivateEventOnIOThread, this, done, result),
639 CreateReceiver(BrowserThread::UI, done, result)); 640 CreateReceiver(BrowserThread::UI, done, result));
640 } 641 }
641 642
643 void DispatchActivateEventOnIOThread(const base::Closure& done,
644 ServiceWorkerStatusCode* result) {
645 ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::IO));
646 int request_id =
647 version_->StartRequest(ServiceWorkerMetrics::EventType::INSTALL,
648 CreateReceiver(BrowserThread::UI, done, result));
649 version_->DispatchSimpleEvent<ServiceWorkerHostMsg_ActivateEventFinished>(
650 request_id, ServiceWorkerMsg_ActivateEvent(request_id));
651 }
652
642 void FetchOnIOThread(const base::Closure& done, 653 void FetchOnIOThread(const base::Closure& done,
643 bool* prepare_result, 654 bool* prepare_result,
644 FetchResult* result) { 655 FetchResult* result) {
645 ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::IO)); 656 ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::IO));
646 ServiceWorkerFetchRequest request( 657 ServiceWorkerFetchRequest request(
647 embedded_test_server()->GetURL("/service_worker/empty.html"), 658 embedded_test_server()->GetURL("/service_worker/empty.html"),
648 "GET", 659 "GET",
649 ServiceWorkerHeaderMap(), 660 ServiceWorkerHeaderMap(),
650 Referrer(), 661 Referrer(),
651 false); 662 false);
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
795 } 806 }
796 807
797 IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest, 808 IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest,
798 Activate_NoEventListener) { 809 Activate_NoEventListener) {
799 ActivateTestHelper("/service_worker/worker.js", SERVICE_WORKER_OK); 810 ActivateTestHelper("/service_worker/worker.js", SERVICE_WORKER_OK);
800 ASSERT_EQ(ServiceWorkerVersion::ACTIVATING, version_->status()); 811 ASSERT_EQ(ServiceWorkerVersion::ACTIVATING, version_->status());
801 } 812 }
802 813
803 IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest, Activate_Rejected) { 814 IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest, Activate_Rejected) {
804 ActivateTestHelper("/service_worker/worker_activate_rejected.js", 815 ActivateTestHelper("/service_worker/worker_activate_rejected.js",
805 SERVICE_WORKER_ERROR_ACTIVATE_WORKER_FAILED); 816 SERVICE_WORKER_ERROR_EVENT_WAITUNTIL_REJECTED);
806 } 817 }
807 818
808 IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest, 819 IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest,
809 InstallWithWaitUntil_Rejected) { 820 InstallWithWaitUntil_Rejected) {
810 InstallTestHelper("/service_worker/worker_install_rejected.js", 821 InstallTestHelper("/service_worker/worker_install_rejected.js",
811 SERVICE_WORKER_ERROR_EVENT_WAITUNTIL_REJECTED); 822 SERVICE_WORKER_ERROR_EVENT_WAITUNTIL_REJECTED);
812 } 823 }
813 824
814 IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest, 825 IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest,
815 InstallWithWaitUntil_RejectConsoleMessage) { 826 InstallWithWaitUntil_RejectConsoleMessage) {
(...skipping 482 matching lines...) Expand 10 before | Expand all | Expand 10 after
1298 ASSERT_EQ(SERVICE_WORKER_OK, status); 1309 ASSERT_EQ(SERVICE_WORKER_OK, status);
1299 // Stop the worker. 1310 // Stop the worker.
1300 StopWorker(SERVICE_WORKER_OK); 1311 StopWorker(SERVICE_WORKER_OK);
1301 // Restart the worker. 1312 // Restart the worker.
1302 StartWorker(SERVICE_WORKER_OK); 1313 StartWorker(SERVICE_WORKER_OK);
1303 // Stop the worker. 1314 // Stop the worker.
1304 StopWorker(SERVICE_WORKER_OK); 1315 StopWorker(SERVICE_WORKER_OK);
1305 } 1316 }
1306 1317
1307 } // namespace content 1318 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698