third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp - Issue 1647313003: Continue converting to explicit LayoutUnit constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp

Issue 1647313003: Continue converting to explicit LayoutUnit constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@explicitContstructors

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/ColumnBalancer.h ('K') | « third_party/WebKit/Source/core/layout/shapes/BoxShapeTest.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp

index 2d7d09d5b24a0d8cf5d2bf3d5ae4d1bad2a2a701..5770859606b4089fd05c57f4d555d112b7ad959a 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp

@@ -62,7 +62,7 @@ void LayoutSVGForeignObject::updateLogicalWidth()

{

// FIXME: Investigate in size rounding issues

// FIXME: Remove unnecessary rounding when layout is off ints: webkit.org/b/63656

- setWidth(static_cast<int>(roundf(m_viewport.width())));

+ setWidth(LayoutUnit(static_cast<int>(roundf(m_viewport.width()))));

eae 2016/01/29 23:57:42 fromFloatFloor?

}

void LayoutSVGForeignObject::computeLogicalHeight(LayoutUnit, LayoutUnit logicalTop, LogicalExtentComputedValues& computedValues) const

@@ -70,7 +70,7 @@ void LayoutSVGForeignObject::computeLogicalHeight(LayoutUnit, LayoutUnit logical

// FIXME: Investigate in size rounding issues

// FIXME: Remove unnecessary rounding when layout is off ints: webkit.org/b/63656

// FIXME: Is this correct for vertical writing mode?

- computedValues.m_extent = static_cast<int>(roundf(m_viewport.height()));

+ computedValues.m_extent = LayoutUnit(static_cast<int>(roundf(m_viewport.height())));

computedValues.m_position = logicalTop;

}