Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 1647253002: Add the ability to summarize inferred types based on function-typed parameters. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add the ability to summarize inferred types based on function-typed parameters. There may still be bugs related to generic types. I will follow up with more tests (and fixes if necessary) in further CLs. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/9e7b8daf836a96da4361f80f55d848d8d31a794f

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+472 lines, -132 lines) Patch
M pkg/analyzer/lib/src/dart/element/type.dart View 3 chunks +42 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 19 chunks +135 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 11 chunks +70 lines, -20 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 3 chunks +35 lines, -11 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 chunk +8 lines, -7 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 7 chunks +139 lines, -88 lines 2 comments Download
M pkg/analyzer/tool/summary/idl.dart View 4 chunks +43 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 10 months ago (2016-01-29 20:40:10 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1647253002/diff/1/pkg/analyzer/test/src/summary/summary_common.dart File pkg/analyzer/test/src/summary/summary_common.dart (right): https://codereview.chromium.org/1647253002/diff/1/pkg/analyzer/test/src/summary/summary_common.dart#newcode4008 pkg/analyzer/test/src/summary/summary_common.dart:4008: expect(type.implicitFunctionTypeIndices[0], 1); I think just equality would work ...
4 years, 10 months ago (2016-01-29 20:56:56 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as 9e7b8daf836a96da4361f80f55d848d8d31a794f (presubmit successful).
4 years, 10 months ago (2016-01-29 21:12:21 UTC) #5
Paul Berry
4 years, 10 months ago (2016-01-29 21:13:18 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1647253002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/1647253002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:4008:
expect(type.implicitFunctionTypeIndices[0], 1);
On 2016/01/29 20:56:56, scheglov wrote:
> I think just equality would work fine and replace the two lines above.
> expect(type.implicitFunctionTypeIndices, [1]);

Whoops, I accidentally just landed the CL without fixing this--sorry.  I will
fix in my next CL.

Powered by Google App Engine
This is Rietveld 408576698