Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1647213002: Remove unnecessary ClassLiteral name member and simplify Function.name handling (Closed)

Created:
4 years, 10 months ago by adamk
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, neis
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unnecessary ClassLiteral name member and simplify Function.name handling A class's name is its constructor's name, so there's no need to treat it separately, either in the parser or in code generation. The main parser use of the name is for ES2015 Function.name handling, and this patch also cleans up handling there by adding a new IsAnonymousFunctionDefinition() method to Expression (the name comes from the spec). Also removed unused ParserTraits::DefaultConstructor method. BUG=v8:3699 LOG=n Committed: https://crrev.com/8f89ad740f8a4a4293cd41059bbac93f8f06b8b1 Cr-Commit-Position: refs/heads/master@{#33643}

Patch Set 1 #

Patch Set 2 : Slightly shorter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -122 lines) Patch
M src/ast/ast.h View 6 chunks +22 lines, -16 lines 0 comments Download
M src/ast/prettyprinter.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/parsing/parser.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/parsing/parser.cc View 1 9 chunks +38 lines, -63 lines 0 comments Download
M src/parsing/preparser.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/runtime/runtime.h View 3 chunks +1 line, -3 lines 0 comments Download
M src/runtime/runtime-classes.cc View 3 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
adamk
rossberg: please look at the parser/ast changes bmeurer: OWNERS for full-codegen and compiler neis: FYI, ...
4 years, 10 months ago (2016-01-29 19:57:33 UTC) #2
rossberg
lgtm
4 years, 10 months ago (2016-01-29 20:06:45 UTC) #3
Benedikt Meurer
Nice. LGTM!
4 years, 10 months ago (2016-02-01 06:20:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647213002/20001
4 years, 10 months ago (2016-02-01 17:10:54 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-01 17:44:31 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 17:44:51 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8f89ad740f8a4a4293cd41059bbac93f8f06b8b1
Cr-Commit-Position: refs/heads/master@{#33643}

Powered by Google App Engine
This is Rietveld 408576698