Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1647183002: Move more constant tests to constant_test.dart file. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move more constant tests to constant_test.dart file. I found out that we use HashMap for constant map literals. But then I realized that I we could move more tests into the right place. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/df5d6bd6e1069d0bb6b91f7301043261ec4580bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2223 lines, -2223 lines) Patch
M pkg/analyzer/test/generated/all_the_rest_test.dart View 4 chunks +0 lines, -2223 lines 0 comments Download
M pkg/analyzer/test/generated/constant_test.dart View 3 chunks +2223 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 10 months ago (2016-01-29 16:55:06 UTC) #1
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-01-29 16:56:49 UTC) #2
scheglov
4 years, 10 months ago (2016-01-29 16:58:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
df5d6bd6e1069d0bb6b91f7301043261ec4580bc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698