Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 164713002: Oilpan: improve comment on why types need to be moved into WebCore. (Closed)

Created:
6 years, 10 months ago by sof
Modified:
6 years, 10 months ago
Reviewers:
haraken, tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: improve comment on why types need to be moved into WebCore. Clarify why the explicit move of some type names into WebCore is needed & label it a FIXME. BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167119

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
Source/web/WebSpeechRecognitionResult.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
sof
Please take a look, if you could. The comment as-was got it the wrong way ...
6 years, 10 months ago (2014-02-13 21:16:58 UTC) #1
haraken
LGTM
6 years, 10 months ago (2014-02-13 23:03:32 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 10 months ago (2014-02-13 23:03:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/164713002/1
6 years, 10 months ago (2014-02-13 23:03:50 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 23:04:01 UTC) #5
Message was sent while issue was closed.
Change committed as 167119

Powered by Google App Engine
This is Rietveld 408576698