Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1647093002: [crankshaft] Fix another deopt loop in slow mode for-in. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Fix another deopt loop in slow mode for-in. The for-in slow mode implementation in Crankshaft unconditionally deoptimizes when %ForInFilter returns undefined instead of just skipping the item. Even worse, there's nothing we can learn from that deopt, so we will eventually optimize again and hit exactly the same problem again once we get back to optimized code. R=mvstanton@chromium.org BUG=v8:3650 LOG=n Committed: https://crrev.com/5a7bb33e3f5e513611250d2edb688c3397ed8149 Cr-Commit-Position: refs/heads/master@{#33609}

Patch Set 1 #

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -24 lines) Patch
M src/crankshaft/hydrogen.cc View 1 1 chunk +41 lines, -16 lines 0 comments Download
A + test/mjsunit/regress/regress-3650-3.js View 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-01-29 09:39:56 UTC) #1
mvstanton
lgtm
4 years, 10 months ago (2016-01-29 09:47:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647093002/20001
4 years, 10 months ago (2016-01-29 09:50:24 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-29 10:59:36 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 11:00:19 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5a7bb33e3f5e513611250d2edb688c3397ed8149
Cr-Commit-Position: refs/heads/master@{#33609}

Powered by Google App Engine
This is Rietveld 408576698