Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_context_menu.h

Issue 1647003002: Make bookmark context menu asynchronous (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b564255_move_key_handler_out_of_message_loop
Patch Set: Removed WARN_UNUSED_RESULT (cont.) Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/bookmarks/bookmark_context_menu.h
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_context_menu.h b/chrome/browser/ui/views/bookmarks/bookmark_context_menu.h
index 87679c5b49a1976faa2dfddbd358d8436b5d5c43..5154f6ac2f4bfe41f39c1146dbed61fd9e31ef5a 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_context_menu.h
+++ b/chrome/browser/ui/views/bookmarks/bookmark_context_menu.h
@@ -27,6 +27,9 @@ class BookmarkContextMenuObserver {
// Invoked after the items have been removed from the model.
virtual void DidRemoveBookmarks() = 0;
+ // Invoked when the context menu is closed.
+ virtual void OnContextMenuClosed() = 0;
+
protected:
virtual ~BookmarkContextMenuObserver() {}
};
@@ -64,6 +67,8 @@ class BookmarkContextMenu : public BookmarkContextMenuControllerDelegate,
bool IsCommandEnabled(int command_id) const override;
bool IsCommandVisible(int command_id) const override;
bool ShouldCloseAllMenusOnExecute(int id) override;
+ void OnMenuClosed(views::MenuItemView* menu,
+ views::MenuRunner::RunResult result) override;
// Overridden from BookmarkContextMenuControllerDelegate:
void CloseMenu() override;
« no previous file with comments | « no previous file | chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698