chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h - Issue 1647003002: Make bookmark context menu asynchronous

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h

Issue 1647003002: Make bookmark context menu asynchronous (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b564255_move_key_handler_out_of_message_loop

Patch Set: Removed loggings Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc ('K') | « chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h

index 5e3a4144d2dfb09a78dbdc5d206b588779604fef..42f1c598289f900b21edb5d5f19108e2b73d3715 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h

+++ b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h

@@ -136,10 +136,11 @@ class BookmarkMenuDelegate : public bookmarks::BaseBookmarkModelObserver,

void BookmarkNodeFaviconChanged(bookmarks::BookmarkModel* model,

const bookmarks::BookmarkNode* node) override;

- // BookmarkContextMenu::Observer methods.

+ // BookmarkContextMenuObserver methods.

void WillRemoveBookmarks(

const std::vector<const bookmarks::BookmarkNode*>& bookmarks) override;

void DidRemoveBookmarks() override;

+ void OnContextMenuClosed() override;

private:

friend class BookmarkMenuDelegateTest;