Make bookmark context menu asynchronous

chrome/browser/ui/views/bookmarks/bookmark_context_menu.h

Index: chrome/browser/ui/views/bookmarks/bookmark_context_menu.h
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_context_menu.h b/chrome/browser/ui/views/bookmarks/bookmark_context_menu.h
index 87679c5b49a1976faa2dfddbd358d8436b5d5c43..5154f6ac2f4bfe41f39c1146dbed61fd9e31ef5a 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_context_menu.h
+++ b/chrome/browser/ui/views/bookmarks/bookmark_context_menu.h
@@ -27,6 +27,9 @@ class BookmarkContextMenuObserver {
   // Invoked after the items have been removed from the model.
   virtual void DidRemoveBookmarks() = 0;
 
+  // Invoked when the context menu is closed.
+  virtual void OnContextMenuClosed() = 0;
+
  protected:
   virtual ~BookmarkContextMenuObserver() {}
 };
@@ -64,6 +67,8 @@ class BookmarkContextMenu : public BookmarkContextMenuControllerDelegate,
   bool IsCommandEnabled(int command_id) const override;
   bool IsCommandVisible(int command_id) const override;
   bool ShouldCloseAllMenusOnExecute(int id) override;
+  void OnMenuClosed(views::MenuItemView* menu,

[sky, 2016/02/03 16:51:56]

Remind me, is this called if the menu is closed because the runner is destroyed?

[mohsen, 2016/02/03 22:14:12]

If the runner is destroyed as a result of an ExecuteCommand() this will not be
called. I believe, the runner is not destroyed for bookmark context menu on
ExecuteCommand(), so this will always be called whenever the menu is closed.

[sky, 2016/02/04 03:32:59]

The case I'm worried about is if this object is destroyed while the menu is up.
Does that result in OnMenuClosed?

[mohsen, 2016/02/04 18:59:53]

No, if MenuRunner is deleted, OnMenuClosed is not called on the delegate. For
bookmark context menu, the MenuRunner is only deleted if its owner
(BookmarkBarView or BookmarkMenuDelegate) is deleted which will also delete
context menu and we should have no problem. Right?

+                    views::MenuRunner::RunResult result) override;
 
   // Overridden from BookmarkContextMenuControllerDelegate:
   void CloseMenu() override;