[mojo] Fix unions in Java generated bindings

[mojo] Fix unions in Java generated bindings

{{field.ordinal}} is not defined anymore, which was causing 'None's to
get printed in the generated code. This change makes the tag generation
consistnt with the C++ binding: it assigns ordinals in the order in
which they appear in the file.

BUG=582186
TEST=pipe_control_messages.mojom builds under Java

Committed: https://crrev.com/0c2d2a05cd042a282478ee4a491ebf91a72f82a2
Cr-Commit-Position: refs/heads/master@{#372185}

[Luis Héctor Chávez, 2016-01-28 20:42:42]

lhchavez@chromium.org changed reviewers:
+ yzshen@chromium.org

[Luis Héctor Chávez, 2016-01-28 20:42:42]

PTAL

[yzshen1, 2016-01-28 21:19:43]

LGTM

Thanks a lot!

https://codereview.chromium.org/1646963002/diff/1/mojo/public/tools/bindings/...
File
mojo/public/tools/bindings/generators/java_templates/data_types_definition.tmpl
(right):

https://codereview.chromium.org/1646963002/diff/1/mojo/public/tools/bindings/...
mojo/public/tools/bindings/generators/java_templates/data_types_definition.tmpl:246:
public static final int {{field|ucc}} = {{loop.index - 1}};
nit: you could use loop.index0 which is 0 based.

[Luis Héctor Chávez, 2016-01-28 21:24:06]

https://codereview.chromium.org/1646963002/diff/1/mojo/public/tools/bindings/...
File
mojo/public/tools/bindings/generators/java_templates/data_types_definition.tmpl
(right):

https://codereview.chromium.org/1646963002/diff/1/mojo/public/tools/bindings/...
mojo/public/tools/bindings/generators/java_templates/data_types_definition.tmpl:246:
public static final int {{field|ucc}} = {{loop.index - 1}};
On 2016/01/28 21:19:43, yzshen1 wrote:
> nit: you could use loop.index0 which is 0 based.

Done.

[Luis Héctor Chávez, 2016-01-28 21:24:15]

The CQ bit was checked by lhchavez@chromium.org

[Luis Héctor Chávez, 2016-01-28 21:24:16]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/1646963002/#ps20001
(title: "s/loop.index - 1/loop.index0/")

[commit-bot: I haz the power, 2016-01-28 21:25:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1646963002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1646963002/20001

[commit-bot: I haz the power, 2016-01-28 22:35:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-28 22:36:50]

Description was changed from

==========
[mojo] Fix unions in Java generated bindings

{{field.ordinal}} is not defined anymore, which was causing 'None's to
get printed in the generated code. This change makes the tag generation
consistnt with the C++ binding: it assigns ordinals in the order in
which they appear in the file.

BUG=582186
TEST=pipe_control_messages.mojom builds under Java
==========

to

==========
[mojo] Fix unions in Java generated bindings

{{field.ordinal}} is not defined anymore, which was causing 'None's to
get printed in the generated code. This change makes the tag generation
consistnt with the C++ binding: it assigns ordinals in the order in
which they appear in the file.

BUG=582186
TEST=pipe_control_messages.mojom builds under Java

Committed: https://crrev.com/0c2d2a05cd042a282478ee4a491ebf91a72f82a2
Cr-Commit-Position: refs/heads/master@{#372185}
==========

[commit-bot: I haz the power, 2016-01-28 22:36:51]

Patchset 2 (id:??) landed as
https://crrev.com/0c2d2a05cd042a282478ee4a491ebf91a72f82a2
Cr-Commit-Position: refs/heads/master@{#372185}