Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 1646903002: Revert of NaCl cleanup: Remove now-unneeded initialisation of NaCl libraries (Closed)

Created:
4 years, 10 months ago by fserb
Modified:
4 years, 10 months ago
Reviewers:
Mark Seaborn, bbudge
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of NaCl cleanup: Remove now-unneeded initialisation of NaCl libraries (patchset #1 id:1 of https://codereview.chromium.org/1646733002/ ) Reason for revert: Possibly causing linking failure on main chrome waterfall. Reverting... Original issue's description: > NaCl cleanup: Remove now-unneeded initialisation of NaCl libraries > > The renderer now no longer uses these NaCl libraries, so we don't need > to initialise them on startup in module_ppapi.cc. > > This leaves UrandomFD() unused, so we can remove it. > > BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=2832 > TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation) > > Committed: https://crrev.com/bba02708e8a255c5f9e2898debf68ed0b037b38f > Cr-Commit-Position: refs/heads/master@{#372098} TBR=bbudge@chromium.org,mseaborn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=2832 Committed: https://crrev.com/b9e5a5bb5e41041a54c64d646a227304b2fc2e7b Cr-Commit-Position: refs/heads/master@{#372121}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M components/nacl/renderer/plugin/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/nacl/renderer/plugin/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M components/nacl/renderer/plugin/module_ppapi.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/nacl/renderer/plugin/module_ppapi.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M components/nacl/renderer/plugin/plugin.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M components/nacl/renderer/ppb_nacl_private.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/nacl/renderer/ppb_nacl_private_impl.cc View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fserb
Created Revert of NaCl cleanup: Remove now-unneeded initialisation of NaCl libraries
4 years, 10 months ago (2016-01-28 18:27:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646903002/1
4 years, 10 months ago (2016-01-28 18:28:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 18:30:25 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 18:31:31 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9e5a5bb5e41041a54c64d646a227304b2fc2e7b
Cr-Commit-Position: refs/heads/master@{#372121}

Powered by Google App Engine
This is Rietveld 408576698