Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: components/history/core/browser/history_service.h

Issue 1646893003: Moves shared history test helpers into util classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@history
Patch Set: ASAN. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/history.gypi ('k') | components/history/core/test/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_SERVICE_H_ 5 #ifndef COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_SERVICE_H_
6 #define COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_SERVICE_H_ 6 #define COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_SERVICE_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 563 matching lines...) Expand 10 before | Expand all | Expand 10 after
574 private: 574 private:
575 class BackendDelegate; 575 class BackendDelegate;
576 friend class base::RefCountedThreadSafe<HistoryService>; 576 friend class base::RefCountedThreadSafe<HistoryService>;
577 friend class BackendDelegate; 577 friend class BackendDelegate;
578 friend class favicon::FaviconService; 578 friend class favicon::FaviconService;
579 friend class HistoryBackend; 579 friend class HistoryBackend;
580 friend class HistoryQueryTest; 580 friend class HistoryQueryTest;
581 friend class ::HistoryQuickProviderTest; 581 friend class ::HistoryQuickProviderTest;
582 friend class HistoryServiceTest; 582 friend class HistoryServiceTest;
583 friend class ::HistoryURLProvider; 583 friend class ::HistoryURLProvider;
584 friend class ::HistoryURLProviderTest;
585 friend class ::InMemoryURLIndexTest; 584 friend class ::InMemoryURLIndexTest;
586 friend class ::SyncBookmarkDataTypeControllerTest; 585 friend class ::SyncBookmarkDataTypeControllerTest;
587 friend class ::TestingProfile; 586 friend class ::TestingProfile;
587 friend scoped_ptr<HistoryService> CreateHistoryService(
588 const base::FilePath& history_dir,
589 const std::string& accept_languages,
590 bool create_db);
588 591
589 // Called on shutdown, this will tell the history backend to complete and 592 // Called on shutdown, this will tell the history backend to complete and
590 // will release pointers to it. No other functions should be called once 593 // will release pointers to it. No other functions should be called once
591 // cleanup has happened that may dispatch to the history thread (because it 594 // cleanup has happened that may dispatch to the history thread (because it
592 // will be null). 595 // will be null).
593 // 596 //
594 // In practice, this will be called by the service manager (BrowserProcess) 597 // In practice, this will be called by the service manager (BrowserProcess)
595 // when it is being destroyed. Because that reference is being destroyed, it 598 // when it is being destroyed. Because that reference is being destroyed, it
596 // should be impossible for anybody else to call the service, even if it is 599 // should be impossible for anybody else to call the service, even if it is
597 // still in memory (pending requests may be holding a reference to us). 600 // still in memory (pending requests may be holding a reference to us).
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
864 867
865 // All vended weak pointers are invalidated in Cleanup(). 868 // All vended weak pointers are invalidated in Cleanup().
866 base::WeakPtrFactory<HistoryService> weak_ptr_factory_; 869 base::WeakPtrFactory<HistoryService> weak_ptr_factory_;
867 870
868 DISALLOW_COPY_AND_ASSIGN(HistoryService); 871 DISALLOW_COPY_AND_ASSIGN(HistoryService);
869 }; 872 };
870 873
871 } // namespace history 874 } // namespace history
872 875
873 #endif // COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_SERVICE_H_ 876 #endif // COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_SERVICE_H_
OLDNEW
« no previous file with comments | « components/history.gypi ('k') | components/history/core/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698