components/omnibox/browser/in_memory_url_index_test_util.h - Issue 1646893003: Moves shared history test helpers into util classes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/omnibox/browser/in_memory_url_index_test_util.h

Issue 1646893003: Moves shared history test helpers into util classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@history

Patch Set: Review. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/omnibox/browser/in_memory_url_index.h ('K') | « components/omnibox/browser/in_memory_url_index.h ('k') | components/omnibox/browser/in_memory_url_index_test_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_OMNIBOX_BROWSER_IN_MEMORY_URL_INDEX_TEST_UTIL_H_

	6 #define COMPONENTS_OMNIBOX_BROWSER_IN_MEMORY_URL_INDEX_TEST_UTIL_H_

	7

	8 class InMemoryURLIndex;

	9

	10 void BlockUntilInMemoryURLIndexIsRefreshed(InMemoryURLIndex* index);
	Peter Kasting 2016/01/31 20:30:43 Are you planning on calling this from other test f Are you planning on calling this from other test files in the immediate future? Otherwise we create this whole .h and .cc just for this one function which is currently called in one place; seems overkill. blundell 2016/02/01 08:28:30 (and if it is staying, it could use a comment) Show quoted text On 2016/01/31 20:30:43, Peter Kasting wrote: > Are you planning on calling this from other test files in the immediate future? > Otherwise we create this whole .h and .cc just for this one function which is > currently called in one place; seems overkill. (and if it is staying, it could use a comment) rohitrao (ping after 24h) 2016/02/01 12:46:47 Added a comment. It's called from InMemoryURLInde Show quoted text On 2016/02/01 08:28:30, blundell wrote: > On 2016/01/31 20:30:43, Peter Kasting wrote: > > Are you planning on calling this from other test files in the immediate > future? > > Otherwise we create this whole .h and .cc just for this one function which is > > currently called in one place; seems overkill. > > (and if it is staying, it could use a comment) Added a comment. It's called from InMemoryURLIndexTest, which is the next CL in the pipe.
	11

	12 #endif // COMPONENTS_OMNIBOX_BROWSER_IN_MEMORY_URL_INDEX_TEST_UTIL_H_

OLD	NEW