Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: components/omnibox/browser/in_memory_url_index.h

Issue 1646893003: Moves shared history test helpers into util classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@history
Patch Set: Review. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_OMNIBOX_BROWSER_IN_MEMORY_URL_INDEX_H_ 5 #ifndef COMPONENTS_OMNIBOX_BROWSER_IN_MEMORY_URL_INDEX_H_
6 #define COMPONENTS_OMNIBOX_BROWSER_IN_MEMORY_URL_INDEX_H_ 6 #define COMPONENTS_OMNIBOX_BROWSER_IN_MEMORY_URL_INDEX_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <functional> 10 #include <functional>
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 144
145 // Indicates that the index restoration is complete. 145 // Indicates that the index restoration is complete.
146 bool restored() const { 146 bool restored() const {
147 return restored_; 147 return restored_;
148 } 148 }
149 149
150 private: 150 private:
151 friend class ::HistoryQuickProviderTest; 151 friend class ::HistoryQuickProviderTest;
152 friend class InMemoryURLIndexTest; 152 friend class InMemoryURLIndexTest;
153 friend class InMemoryURLIndexCacheTest; 153 friend class InMemoryURLIndexCacheTest;
154 friend void RebuildInMemoryURLIndex(InMemoryURLIndex* index,
Peter Kasting 2016/01/31 20:30:43 This should be removed
rohitrao (ping after 24h) 2016/02/01 12:46:47 Good catch, thanks.
155 history::HistoryService* history);
154 FRIEND_TEST_ALL_PREFIXES(InMemoryURLIndexTest, ExpireRow); 156 FRIEND_TEST_ALL_PREFIXES(InMemoryURLIndexTest, ExpireRow);
155 FRIEND_TEST_ALL_PREFIXES(LimitedInMemoryURLIndexTest, Initialization); 157 FRIEND_TEST_ALL_PREFIXES(LimitedInMemoryURLIndexTest, Initialization);
156 158
157 // HistoryDBTask used to rebuild our private data from the history database. 159 // HistoryDBTask used to rebuild our private data from the history database.
158 class RebuildPrivateDataFromHistoryDBTask : public history::HistoryDBTask { 160 class RebuildPrivateDataFromHistoryDBTask : public history::HistoryDBTask {
159 public: 161 public:
160 explicit RebuildPrivateDataFromHistoryDBTask( 162 explicit RebuildPrivateDataFromHistoryDBTask(
161 InMemoryURLIndex* index, 163 InMemoryURLIndex* index,
162 const std::string& languages, 164 const std::string& languages,
163 const SchemeSet& scheme_whitelist); 165 const SchemeSet& scheme_whitelist);
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
318 // This flag is set to true if we want to listen to the 320 // This flag is set to true if we want to listen to the
319 // HistoryServiceLoaded Notification. 321 // HistoryServiceLoaded Notification.
320 bool listen_to_history_service_loaded_; 322 bool listen_to_history_service_loaded_;
321 323
322 base::ThreadChecker thread_checker_; 324 base::ThreadChecker thread_checker_;
323 325
324 DISALLOW_COPY_AND_ASSIGN(InMemoryURLIndex); 326 DISALLOW_COPY_AND_ASSIGN(InMemoryURLIndex);
325 }; 327 };
326 328
327 #endif // COMPONENTS_OMNIBOX_BROWSER_IN_MEMORY_URL_INDEX_H_ 329 #endif // COMPONENTS_OMNIBOX_BROWSER_IN_MEMORY_URL_INDEX_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698