content/public/gpu/DEPS - Issue 1646853002: Add embedder api for participating in gpu logic

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/gpu/DEPS

Issue 1646853002: Add embedder api for participating in gpu logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 include_rules = [

	2 "+content/browser/gpu",
	jam 2016/01/28 16:47:36 huh? why is this? content/gpu can't depend on cont huh? why is this? content/gpu can't depend on content/browser kcwu 2016/01/28 17:55:30 This is for implementation of gpu_service_registry Show quoted text On 2016/01/28 16:47:36, jam wrote: > huh? why is this? content/gpu can't depend on content/browser This is for implementation of gpu_service_registry.cc. So, I'm wondering maybe gpu_service_registry.{cc,h} should be in content/public/browser ? jam 2016/01/28 21:13:39 Where do you want the code in gpu_service_registry Show quoted text On 2016/01/28 17:55:30, kcwu wrote: > On 2016/01/28 16:47:36, jam wrote: > > huh? why is this? content/gpu can't depend on content/browser > > This is for implementation of gpu_service_registry.cc. > So, I'm wondering maybe gpu_service_registry.{cc,h} should be in > content/public/browser ? Where do you want the code in gpu_service_registry.cc to run? If you want it to run in the browser process, it should be in content/browser (or content/public/browser). If you want it to run in the gpu process, it should be in content/gpu (or content/public/gpu). kcwu 2016/01/29 17:22:44 Done. Show quoted text On 2016/01/28 21:13:39, jam wrote: > On 2016/01/28 17:55:30, kcwu wrote: > > On 2016/01/28 16:47:36, jam wrote: > > > huh? why is this? content/gpu can't depend on content/browser > > > > This is for implementation of gpu_service_registry.cc. > > So, I'm wondering maybe gpu_service_registry.{cc,h} should be in > > content/public/browser ? > > Where do you want the code in gpu_service_registry.cc to run? If you want it to > run in the browser process, it should be in content/browser (or > content/public/browser). If you want it to run in the gpu process, it should be > in content/gpu (or content/public/gpu). Done.
	3 ]

OLD	NEW

« content/app/content_main_runner.cc ('K') | « content/public/gpu/BUILD.gn ('k') | content/public/gpu/content_gpu_client.h » ('j') | content/public/gpu/gpu_service_registry.h » ('J')