Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1646823004: rewrite_to_chrome_style: fix windows build (Closed)

Created:
4 years, 10 months ago by dcheng
Modified:
4 years, 10 months ago
Reviewers:
danakj
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

rewrite_to_chrome_style: fix windows build - VS2013 doesn't support constexpr - windows.h defines helpful things like min and max macros - Use HANDLE instead of HFILE BUG=none Committed: https://crrev.com/024f2aa0f1ec971346818bd37ca20b5d431d321c Cr-Commit-Position: refs/heads/master@{#372230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp View 5 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dcheng
Note: I haven't actually tried running it, but having it compile is a good first ...
4 years, 10 months ago (2016-01-29 00:18:06 UTC) #2
danakj
> - windows.h defines helpful things like min and max macros lol LGTM
4 years, 10 months ago (2016-01-29 00:19:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646823004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646823004/1
4 years, 10 months ago (2016-01-29 00:29:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 00:52:34 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 00:53:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/024f2aa0f1ec971346818bd37ca20b5d431d321c
Cr-Commit-Position: refs/heads/master@{#372230}

Powered by Google App Engine
This is Rietveld 408576698