Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: build/common.gypi

Issue 1646813004: Reassign all of earthdok's TODOs and remove from OWNERS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: reassign Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/sanitizers/OWNERS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 4370 matching lines...) Expand 10 before | Expand all | Expand 10 after
4381 'MEMORY_SANITIZER_INITIAL_SIZE', 4381 'MEMORY_SANITIZER_INITIAL_SIZE',
4382 ], 4382 ],
4383 }], 4383 }],
4384 ], 4384 ],
4385 }], 4385 }],
4386 ['asan==1', { 4386 ['asan==1', {
4387 'target_conditions': [ 4387 'target_conditions': [
4388 ['_toolset=="target"', { 4388 ['_toolset=="target"', {
4389 'cflags': [ 4389 'cflags': [
4390 '-fsanitize=address', 4390 '-fsanitize=address',
4391 # TODO(earthdok): Re-enable. http://crbug.com/427202 4391 # TODO(eugenis): Re-enable. http://crbug.com/427202
4392 #'-fsanitize-blacklist=<(asan_blacklist)', 4392 #'-fsanitize-blacklist=<(asan_blacklist)',
4393 ], 4393 ],
4394 'ldflags': [ 4394 'ldflags': [
4395 '-fsanitize=address', 4395 '-fsanitize=address',
4396 ], 4396 ],
4397 }], 4397 }],
4398 ], 4398 ],
4399 'conditions': [ 4399 'conditions': [
4400 ['OS=="mac"', { 4400 ['OS=="mac"', {
4401 'cflags': [ 4401 'cflags': [
(...skipping 1986 matching lines...) Expand 10 before | Expand all | Expand 10 after
6388 # settings in target dicts. SYMROOT is a special case, because many other 6388 # settings in target dicts. SYMROOT is a special case, because many other
6389 # Xcode variables depend on it, including variables such as 6389 # Xcode variables depend on it, including variables such as
6390 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6390 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6391 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6391 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6392 # files to appear (when present) in the UI as actual files and not red 6392 # files to appear (when present) in the UI as actual files and not red
6393 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6393 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6394 # and therefore SYMROOT, needs to be set at the project level. 6394 # and therefore SYMROOT, needs to be set at the project level.
6395 'SYMROOT': '<(DEPTH)/xcodebuild', 6395 'SYMROOT': '<(DEPTH)/xcodebuild',
6396 }, 6396 },
6397 } 6397 }
OLDNEW
« no previous file with comments | « no previous file | build/sanitizers/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698