Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1646813003: Revert of MIPS: Add FPXX support to MIPS32R2 (Closed)

Created:
4 years, 10 months ago by ivica.bogosavljevic
Modified:
4 years, 10 months ago
Reviewers:
ilija.pavlovic, balazs.kilvady, miran.karic, Marija Antic, akos.palfi.imgtec, gergely.kis.imgtec, paul.l...
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of MIPS: Add FPXX support to MIPS32R2 (patchset #3 id:40001 of https://codereview.chromium.org/1586223004/ ) Reason for revert: Revert patch due to a number of failures appearing on the MIPS v8 simulator Original issue's description: > MIPS: Add FPXX support to MIPS32R2 > > The JIT code generated by V8 is FPXX compliant > when v8 compiled with FPXX flag. This allows the code to > run in both FP=1 and FP=0 mode. It also alows v8 to be used > as a library by both FP32 and FP64 binaries. > > BUG= > > Committed: https://crrev.com/95110dde666158a230a823fd50a68558ad772320 > Cr-Commit-Position: refs/heads/master@{#33576} TBR=paul.lind@imgtec.com,gergely.kis@imgtec.com,akos.palfi@imgtec.com,ilija.pavlovic@imgtec.com,marija.antic@imgtec.com,miran.karic@imgtec.com,balazs.kilvady@imgtec.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/ca404f3c1568b592f7a88c5199c79b5c58e78cd0 Cr-Commit-Position: refs/heads/master@{#33583}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -61 lines) Patch
M src/mips/assembler-mips.cc View 4 chunks +2 lines, -34 lines 0 comments Download
M src/mips/constants-mips.h View 2 chunks +9 lines, -9 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 6 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ivica.bogosavljevic
Created Revert of MIPS: Add FPXX support to MIPS32R2
4 years, 10 months ago (2016-01-28 11:53:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646813003/1
4 years, 10 months ago (2016-01-28 11:53:41 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 10 months ago (2016-01-28 11:53:42 UTC) #4
akos.palfi.imgtec
Lgtm
4 years, 10 months ago (2016-01-28 13:08:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646813003/1
4 years, 10 months ago (2016-01-28 13:09:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 13:09:33 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 13:09:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca404f3c1568b592f7a88c5199c79b5c58e78cd0
Cr-Commit-Position: refs/heads/master@{#33583}

Powered by Google App Engine
This is Rietveld 408576698