Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollState.idl

Issue 1646663002: Refactor Scroll Customization to share cc::ScrollStateData with blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix linking more. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/scrolling/ScrollState.idl
diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollState.idl b/third_party/WebKit/Source/core/page/scrolling/ScrollState.idl
index 228d973a682fe82b9b54840c35d2fc263f45f172..66cf922ef0153ca0bf66d4e63156e914e9464552 100644
--- a/third_party/WebKit/Source/core/page/scrolling/ScrollState.idl
+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollState.idl
@@ -5,27 +5,36 @@
// https://docs.google.com/document/d/1VnvAqeWFG9JFZfgG5evBqrLGDZYRE5w6G5jEDORekPY
[
- Constructor(optional double deltaX = 0,
- optional double deltaY = 0,
- optional double deltaGranularity = 0,
- optional double velocityX = 0,
- optional double velocityY = 0,
- optional boolean inInertialPhase = false,
- optional boolean isBeginning = false,
- optional boolean isEnding = false),
- WillBeGarbageCollected,
- RuntimeEnabled=ScrollCustomization
-] interface ScrollState {
+ Constructor(optional double deltaX = 0,
+ optional double deltaY = 0,
+ optional long startPositionX = 0,
+ optional long startPositionY = 0,
+ optional double velocityX = 0,
+ optional double velocityY = 0,
+ optional boolean isBeginning = false,
+ optional boolean inInertialPhase = false,
+ optional boolean isEnding = false,
+ optional boolean shouldPropagate = true,
+ optional boolean fromUserInput = false,
+ optional boolean isDirectManipulation = false,
+ optional double deltaGranularity = 0),
Ian Vollick 2016/02/08 18:30:35 nit: Could we pass a dictionary? There are quite a
+ WillBeGarbageCollected,
+ RuntimeEnabled = ScrollCustomization,
+] interface ScrollState
+{
readonly attribute double deltaX;
readonly attribute double deltaY;
- readonly attribute double deltaGranularity;
+ readonly attribute long startPositionX;
+ readonly attribute long startPositionY;
readonly attribute double velocityX;
readonly attribute double velocityY;
+ readonly attribute boolean isBeginning;
readonly attribute boolean inInertialPhase;
readonly attribute boolean isEnding;
- readonly attribute boolean isBeginning;
- readonly attribute boolean fromUserInput;
readonly attribute boolean shouldPropagate;
+ readonly attribute boolean fromUserInput;
+ readonly attribute boolean isDirectManipulation;
+ readonly attribute double deltaGranularity;
[RaisesException] void consumeDelta(double x, double y);
void distributeToScrollChainDescendant();

Powered by Google App Engine
This is Rietveld 408576698