Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: third_party/WebKit/LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-basic.html

Issue 1646663002: Refactor Scroll Customization to share cc::ScrollStateData with blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix linking more. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-basic.html
diff --git a/third_party/WebKit/LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-basic.html b/third_party/WebKit/LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-basic.html
index ad320eb03746887c8cea25c667d7befe9c39e292..3788f75219178e650ebd6e8b42bfa33abd04fc87 100644
--- a/third_party/WebKit/LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-basic.html
+++ b/third_party/WebKit/LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-basic.html
@@ -31,24 +31,34 @@ if ('ScrollState' in window) {
test(function() {
var deltaX = 12.5;
var deltaY = 14.9;
- var deltaGranularity = 148.3;
+ var startPositionX = 16.82;
+ var startPositionY = 82.17;
var velocityX = 23.7;
var velocityY = 2.5;
- var inInertialPhase = true;
var isBeginning = true;
+ var inInertialPhase = true;
var isEnding = true;
- var scrollState = new ScrollState(deltaX, deltaY, deltaGranularity, velocityX,
- velocityY, inInertialPhase, isBeginning, isEnding);
+ var shouldPropagate = false;
+ var fromUserInput = true;
+ var isDirectManipulation = true;
+ var deltaGranularity = 148.3;
+ var scrollState = new ScrollState(deltaX, deltaY, startPositionX, startPositionY,
+ velocityX, velocityY, isBeginning, inInertialPhase,
+ isEnding, shouldPropagate, fromUserInput,
+ isDirectManipulation, deltaGranularity);
assert_equals(scrollState.deltaX, deltaX);
assert_equals(scrollState.deltaY, deltaY);
- assert_equals(scrollState.deltaGranularity, deltaGranularity);
+ assert_equals(scrollState.startPositionX, Math.floor(startPositionX));
+ assert_equals(scrollState.startPositionY, Math.floor(startPositionY));
assert_equals(scrollState.velocityX, velocityX);
assert_equals(scrollState.velocityY, velocityY);
- assert_equals(scrollState.inInertialPhase, inInertialPhase);
assert_equals(scrollState.isBeginning, isBeginning);
+ assert_equals(scrollState.inInertialPhase, inInertialPhase);
assert_equals(scrollState.isEnding, isEnding);
- assert_equals(scrollState.fromUserInput, false);
- assert_equals(scrollState.shouldPropagate, true);
+ assert_equals(scrollState.shouldPropagate, shouldPropagate);
+ assert_equals(scrollState.fromUserInput, fromUserInput);
+ assert_equals(scrollState.isDirectManipulation, isDirectManipulation);
+ assert_equals(scrollState.deltaGranularity, deltaGranularity);
}, "Constructor behaves correctly.");
test(function() {

Powered by Google App Engine
This is Rietveld 408576698