Refactor Scroll Customization to share cc::ScrollStateData with blink.

Refactor Scroll Customization to share cc::ScrollStateData with blink.

This will make it easier for Scroll Customization on the compositor
worker to pass ScrollState objects back and forth between main and the
compositor.

BUG=505851
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/ebe6e34c371190558db374f42a12893e525cc081
Cr-Commit-Position: refs/heads/master@{#374691}

[tdresser, 2016-01-27 20:22:55]

Description was changed from

==========
Refactor Scroll Customization to share cc::ScrollStateData with blink.

This will make it easier for Scroll Customization on the compositor
worker to pass ScrollState objects back and forth between main and the
compositor.

BUG=505851
==========

to

==========
Refactor Scroll Customization to share cc::ScrollStateData with blink.

This will make it easier for Scroll Customization on the compositor
worker to pass ScrollState objects back and forth between main and the
compositor.

BUG=505851
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[tdresser, 2016-01-27 20:23:27]

The CQ bit was checked by tdresser@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-27 20:26:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1646663002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1646663002/1

[commit-bot: I haz the power, 2016-01-27 20:49:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 20:49:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tdresser, 2016-01-29 16:06:18]

The CQ bit was checked by tdresser@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-29 16:06:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1646663002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1646663002/20001

[commit-bot: I haz the power, 2016-01-29 16:26:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 16:26:22]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tdresser, 2016-02-01 18:16:17]

The CQ bit was checked by tdresser@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-01 18:16:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1646663002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1646663002/40001

[commit-bot: I haz the power, 2016-02-01 18:39:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-01 18:39:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tdresser, 2016-02-03 18:14:55]

The CQ bit was checked by tdresser@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-03 18:17:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1646663002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1646663002/60001

[commit-bot: I haz the power, 2016-02-03 19:58:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-03 19:58:42]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[tdresser, 2016-02-04 14:50:38]

The CQ bit was checked by tdresser@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-04 14:50:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1646663002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1646663002/80001

[commit-bot: I haz the power, 2016-02-04 16:28:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-04 16:28:49]

Dry run: This issue passed the CQ dry run.

[tdresser, 2016-02-04 16:31:52]

tdresser@chromium.org changed reviewers:
+ vollick@chromium.org

[tdresser, 2016-02-04 16:31:52]

PTAL

[tdresser, 2016-02-08 15:43:51]

Ping.

[tdresser, 2016-02-08 16:02:33]

tdresser@chromium.org changed reviewers:
+ jbroman@chromium.org

[jbroman, 2016-02-08 16:09:30]

core.gyp lgtm

https://codereview.chromium.org/1646663002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/core.gyp (right):

https://codereview.chromium.org/1646663002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/core.gyp:662: '<(DEPTH)/cc/cc.gyp:cc',
Yeah, looks like this is necessary due to inlining the superclass constructor
call in blink::ScrollStateData, which is analogous to the reason for the
base.gyp:base dependency above (and also to the link dependency that already
exists in the GN build).

[Ian Vollick, 2016-02-08 18:30:35]

https://codereview.chromium.org/1646663002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/page/scrolling/ScrollState.idl (right):

https://codereview.chromium.org/1646663002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/page/scrolling/ScrollState.idl:20: optional
double deltaGranularity = 0),
nit: Could we pass a dictionary? There are quite a few parameters here. Offline
Tim suggested we might have fewer ctor parameters and use setters to change
things after construction. That seems like a good idea and might simplify more
than just the JS ctor.

[tdresser, 2016-02-09 18:21:14]

The CQ bit was checked by tdresser@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-09 18:23:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1646663002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1646663002/100001

[commit-bot: I haz the power, 2016-02-09 18:44:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 18:44:20]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tdresser, 2016-02-09 21:32:57]

The CQ bit was checked by tdresser@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-09 21:39:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1646663002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1646663002/120001

[commit-bot: I haz the power, 2016-02-09 23:12:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 23:12:01]

Dry run: This issue passed the CQ dry run.

[tdresser, 2016-02-10 14:14:35]

PTAL.

This is currently a bit loose with the is_ending bit (with respect to fling) and
the starting_position_{x,y} bits, but I think it makes sense to clean those up
in a future patch.

[Ian Vollick, 2016-02-10 14:24:42]

On 2016/02/10 14:14:35, tdresser wrote:
> PTAL.
> 
> This is currently a bit loose with the is_ending bit (with respect to fling)
and
> the starting_position_{x,y} bits, but I think it makes sense to clean those up
> in a future patch.

That's far easier to read, thanks! This lgtm, but I'm not an OWNER of web/ or
public/platform/.

[tdresser, 2016-02-10 14:37:22]

tdresser@chromium.org changed reviewers:
+ bokan@chromium.org

[tdresser, 2016-02-10 14:37:22]

+bokan@ for third_party/WebKit/Source/web/web.gyp.
This change is needed for the same reason as the core.gyp change, which jbroman@
commented on.

+dcheng@ for deletion of third_party/WebKit/public/platform/WebScrollStateData.h
and 1 line change in
third_party/WebKit/public/blink_headers.gypi

[tdresser, 2016-02-10 14:37:42]

tdresser@chromium.org changed reviewers:
+ dcheng@chromium.org

[tdresser, 2016-02-10 14:37:43]

+dcheng@ for real.

[bokan, 2016-02-10 16:46:26]

third_party/WebKit/Source/web/web.gyp lgtm

[dcheng, 2016-02-10 18:17:32]

rs lgtm for third_party/WebKit/public changes

[tdresser, 2016-02-10 18:36:35]

The CQ bit was checked by tdresser@chromium.org

[tdresser, 2016-02-10 18:36:35]

The patchset sent to the CQ was uploaded after l-g-t-m from jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/1646663002/#ps120001
(title: "Fix linking.")

[commit-bot: I haz the power, 2016-02-10 18:37:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1646663002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1646663002/120001

[commit-bot: I haz the power, 2016-02-10 18:46:21]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-02-10 18:47:45]

Description was changed from

==========
Refactor Scroll Customization to share cc::ScrollStateData with blink.

This will make it easier for Scroll Customization on the compositor
worker to pass ScrollState objects back and forth between main and the
compositor.

BUG=505851
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Refactor Scroll Customization to share cc::ScrollStateData with blink.

This will make it easier for Scroll Customization on the compositor
worker to pass ScrollState objects back and forth between main and the
compositor.

BUG=505851
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/ebe6e34c371190558db374f42a12893e525cc081
Cr-Commit-Position: refs/heads/master@{#374691}
==========

[commit-bot: I haz the power, 2016-02-10 18:47:47]

Patchset 7 (id:??) landed as
https://crrev.com/ebe6e34c371190558db374f42a12893e525cc081
Cr-Commit-Position: refs/heads/master@{#374691}