Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1646633002: Revert of Add extensions parameter to Pylint presubmit check. (Closed)

Created:
4 years, 11 months ago by dtu
Modified:
4 years, 11 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Add extensions parameter to Pylint presubmit check. (patchset #1 id:1 of https://codereview.chromium.org/1639493003/ ) Reason for revert: Sorry, turns out this change isn't necessary. You can specify extension-pkg-whitelist in pylintrc. Original issue's description: > Add extensions parameter to Pylint presubmit check. > > This allows Pylint to analyze code that relies on C extensions (like numpy). > https://bitbucket.org/logilab/pylint/issues/58#comment-14920640 > > > BUG= > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298392 TBR=dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298419

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M presubmit_canned_checks.py View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
dtu
Created Revert of Add extensions parameter to Pylint presubmit check.
4 years, 11 months ago (2016-01-27 20:06:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646633002/1
4 years, 11 months ago (2016-01-27 20:06:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=298419
4 years, 11 months ago (2016-01-27 20:08:51 UTC) #4
Dirk Pranke
4 years, 11 months ago (2016-01-27 22:22:39 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698