Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 1646623003: Extend asserts in BaseChromiumApplication to cover ToolbarCallbackWrapper (Closed)

Created:
4 years, 10 months ago by Theresa
Modified:
4 years, 10 months ago
Reviewers:
Yaron
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extend asserts in BaseChromiumApplication to cover ToolbarCallbackWrapper Our enhanced bookmark activities call a method that ends up wrapping our window callback proxy. Our asserts in BaseChromiumApplication fail because the class of the Window callback has been changed. Extend the asserts to cover the ToolbarCallbackWrapper case. BUG=581927 Committed: https://crrev.com/587840943312698e8de4714d21673788c4eaf16b Cr-Commit-Position: refs/heads/master@{#372168}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M base/android/java/src/org/chromium/base/BaseChromiumApplication.java View 1 2 chunks +20 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Theresa
ptal
4 years, 10 months ago (2016-01-28 19:45:22 UTC) #3
Yaron
On 2016/01/28 19:45:22, Theresa Wellington wrote: > ptal yikes! not pretty but since it's all ...
4 years, 10 months ago (2016-01-28 19:53:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646623003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646623003/20001
4 years, 10 months ago (2016-01-28 20:45:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-28 21:16:07 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 21:16:52 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/587840943312698e8de4714d21673788c4eaf16b
Cr-Commit-Position: refs/heads/master@{#372168}

Powered by Google App Engine
This is Rietveld 408576698