Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1646613002: PPC: [regexp] correctly advance zero length matches for global/unicode. (Closed)

Created:
4 years, 10 months ago by MTBrandyberry
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [regexp] correctly advance zero length matches for global/unicode. Port 57d202d879dbf7589a7d2c1466b2698d3a2d9c21 R=yangguo@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:2952 LOG=N Committed: https://crrev.com/510f4a9b8f836de4e49f08bd044a8f49b8038f51 Cr-Commit-Position: refs/heads/master@{#33566}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/regexp/ppc/regexp-macro-assembler-ppc.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
4 years, 10 months ago (2016-01-27 19:16:05 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646613002/1
4 years, 10 months ago (2016-01-27 19:16:21 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-27 19:56:59 UTC) #5
john.yan
lgtm
4 years, 10 months ago (2016-01-27 20:59:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646613002/1
4 years, 10 months ago (2016-01-27 21:04:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-27 21:07:08 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-01-27 21:07:37 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/510f4a9b8f836de4e49f08bd044a8f49b8038f51
Cr-Commit-Position: refs/heads/master@{#33566}

Powered by Google App Engine
This is Rietveld 408576698