Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1646603002: Make fuzz output the words success for a 'clean exit' (Closed)

Created:
4 years, 11 months ago by kjlubick
Modified:
4 years, 11 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make fuzz output the words success for a 'clean exit' The analysis looks for "Success" to determine if the fuzz should be considered a clean exit or not. It classifies clean exists as "grey" fuzzes, i.e. fixed. TBR=mtklein@google.com BUG=skia:4438 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1646603002 Committed: https://skia.googlesource.com/skia/+/2b6aa21817ce600d280fe29cc088cc86ebd5d514

Patch Set 1 #

Patch Set 2 : Fix syntax error #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M fuzz/fuzz.cpp View 1 2 chunks +2 lines, -1 line 1 comment Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646603002/1
4 years, 11 months ago (2016-01-27 19:14:31 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/5662) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, ...
4 years, 11 months ago (2016-01-27 19:15:40 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646603002/20001
4 years, 11 months ago (2016-01-27 19:18:58 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-27 19:32:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646603002/20001
4 years, 11 months ago (2016-01-27 19:34:13 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/2b6aa21817ce600d280fe29cc088cc86ebd5d514
4 years, 11 months ago (2016-01-27 19:34:39 UTC) #13
mtklein
4 years, 11 months ago (2016-01-27 19:34:44 UTC) #14
Message was sent while issue was closed.
https://codereview.chromium.org/1646603002/diff/20001/fuzz/fuzz.cpp
File fuzz/fuzz.cpp (right):

https://codereview.chromium.org/1646603002/diff/20001/fuzz/fuzz.cpp#newcode69
fuzz/fuzz.cpp:69: SkDebugf("Success!");
Add \n?

Powered by Google App Engine
This is Rietveld 408576698