Deprecate media_task_runner() from FileSystemTaskRunners

Deprecate media_task_runner() from FileSystemTaskRunners

It looks we no longer need to keep the value there.

BUG=241701
TEST=green bots
R=thestig@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205137

[kinuko, 2013-06-06 12:20:59]

Steve, now that we've moved all media related code into c/b/media_galleries we
seem to be able to deprecate media_task_runner in fileapi code too.  Can you
take a look?  Thanks,

[vandebo (ex-Chrome), 2013-06-06 20:10:16]

I'll take a look Monday if Lei doesn't get to it first.

[Lei Zhang, 2013-06-06 22:31:11]

lgtm with some nits

https://codereview.chromium.org/16466006/diff/16001/chrome/browser/media_gall...
File
chrome/browser/media_galleries/fileapi/media_file_system_mount_point_provider.h
(right):

https://codereview.chromium.org/16466006/diff/16001/chrome/browser/media_gall...
chrome/browser/media_galleries/fileapi/media_file_system_mount_point_provider.h:33:
explicit MediaFileSystemMountPointProvider(
no longer explicit

https://codereview.chromium.org/16466006/diff/16001/content/browser/fileapi/b...
File content/browser/fileapi/browser_file_system_helper.cc (right):

https://codereview.chromium.org/16466006/diff/16001/content/browser/fileapi/b...
content/browser/fileapi/browser_file_system_helper.cc:12: #include
"base/threading/sequenced_worker_pool.h"
remove

https://codereview.chromium.org/16466006/diff/16001/webkit/browser/fileapi/fi...
File webkit/browser/fileapi/file_system_task_runners.cc (right):

https://codereview.chromium.org/16466006/diff/16001/webkit/browser/fileapi/fi...
webkit/browser/fileapi/file_system_task_runners.cc:8: #include
"base/sequenced_task_runner.h"
remove

https://codereview.chromium.org/16466006/diff/16001/webkit/browser/fileapi/fi...
File webkit/browser/fileapi/file_system_task_runners.h (right):

https://codereview.chromium.org/16466006/diff/16001/webkit/browser/fileapi/fi...
webkit/browser/fileapi/file_system_task_runners.h:13: class SequencedTaskRunner;
remove

[kinuko, 2013-06-07 07:19:24]

Thanks, updated.

https://codereview.chromium.org/16466006/diff/16001/chrome/browser/media_gall...
File
chrome/browser/media_galleries/fileapi/media_file_system_mount_point_provider.h
(right):

https://codereview.chromium.org/16466006/diff/16001/chrome/browser/media_gall...
chrome/browser/media_galleries/fileapi/media_file_system_mount_point_provider.h:33:
explicit MediaFileSystemMountPointProvider(
On 2013/06/06 22:31:12, Lei Zhang wrote:
> no longer explicit

Done.

https://codereview.chromium.org/16466006/diff/16001/content/browser/fileapi/b...
File content/browser/fileapi/browser_file_system_helper.cc (right):

https://codereview.chromium.org/16466006/diff/16001/content/browser/fileapi/b...
content/browser/fileapi/browser_file_system_helper.cc:12: #include
"base/threading/sequenced_worker_pool.h"
On 2013/06/06 22:31:12, Lei Zhang wrote:
> remove

Done.

https://codereview.chromium.org/16466006/diff/16001/webkit/browser/fileapi/fi...
File webkit/browser/fileapi/file_system_task_runners.cc (right):

https://codereview.chromium.org/16466006/diff/16001/webkit/browser/fileapi/fi...
webkit/browser/fileapi/file_system_task_runners.cc:8: #include
"base/sequenced_task_runner.h"
On 2013/06/06 22:31:12, Lei Zhang wrote:
> remove

Done.

https://codereview.chromium.org/16466006/diff/16001/webkit/browser/fileapi/fi...
File webkit/browser/fileapi/file_system_task_runners.h (right):

https://codereview.chromium.org/16466006/diff/16001/webkit/browser/fileapi/fi...
webkit/browser/fileapi/file_system_task_runners.h:13: class SequencedTaskRunner;
On 2013/06/06 22:31:12, Lei Zhang wrote:
> remove

Done.

[kinuko, 2013-06-07 14:03:38]

I'll be CQ-ing this. Steve, please just uncheck it if anything doesn't look good
to you.

[commit-bot: I haz the power, 2013-06-07 14:03:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinuko@chromium.org/16466006/34001

[commit-bot: I haz the power, 2013-06-07 14:03:55]

Failed to apply patch for
chrome/browser/media_galleries/imported_media_gallery_registry.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
chrome/browser/media_galleries/imported_media_gallery_registry.cc
  Hunk #1 FAILED at 7.
  Hunk #2 succeeded at 23 (offset 1 line).
  Hunk #3 succeeded at 33 (offset 1 line).
  Hunk #4 succeeded at 42 (offset 1 line).
  1 out of 4 hunks FAILED -- saving rejects to file
chrome/browser/media_galleries/imported_media_gallery_registry.cc.rej

Patch:       chrome/browser/media_galleries/imported_media_gallery_registry.cc
Index: chrome/browser/media_galleries/imported_media_gallery_registry.cc
diff --git a/chrome/browser/media_galleries/imported_media_gallery_registry.cc
b/chrome/browser/media_galleries/imported_media_gallery_registry.cc
index
0a17c82cf4293d7abe4b9116df31e6ffdc6c03b8..d6266a48adfe9b4f31ec677d65b9173a16f2dd9b
100644
--- a/chrome/browser/media_galleries/imported_media_gallery_registry.cc
+++ b/chrome/browser/media_galleries/imported_media_gallery_registry.cc
@@ -7,10 +7,10 @@
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/threading/sequenced_worker_pool.h"
+#include
"chrome/browser/media_galleries/fileapi/media_file_system_mount_point_provider.h"
 #include "chrome/browser/media_galleries/fileapi/picasa/picasa_data_provider.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "content/public/browser/browser_thread.h"
-#include "webkit/browser/fileapi/file_system_task_runners.h"
 #include "webkit/browser/fileapi/isolated_context.h"
 
 using base::Bind;
@@ -22,7 +22,8 @@ namespace {
 bool CurrentlyOnMediaTaskRunnerThread() {
   base::SequencedWorkerPool* pool = content::BrowserThread::GetBlockingPool();
   base::SequencedWorkerPool::SequenceToken media_sequence_token =
-      pool->GetNamedSequenceToken(fileapi::kMediaTaskRunnerName);
+      pool->GetNamedSequenceToken(
+          MediaFileSystemMountPointProvider::kMediaTaskRunnerName);
 
   return pool->IsRunningSequenceOnCurrentThread(media_sequence_token);
 }
@@ -31,7 +32,8 @@ scoped_refptr<base::SequencedTaskRunner> MediaTaskRunner() {
   DCHECK(!CurrentlyOnMediaTaskRunnerThread());
   base::SequencedWorkerPool* pool = content::BrowserThread::GetBlockingPool();
   base::SequencedWorkerPool::SequenceToken media_sequence_token =
-      pool->GetNamedSequenceToken(fileapi::kMediaTaskRunnerName);
+      pool->GetNamedSequenceToken(
+          MediaFileSystemMountPointProvider::kMediaTaskRunnerName);
 
   return pool->GetSequencedTaskRunner(media_sequence_token);
 }
@@ -39,7 +41,7 @@ scoped_refptr<base::SequencedTaskRunner> MediaTaskRunner() {
 static base::LazyInstance<ImportedMediaGalleryRegistry>::Leaky
 g_imported_media_gallery_registry = LAZY_INSTANCE_INITIALIZER;
 
-}
+}  // namespace
 
 // static
 ImportedMediaGalleryRegistry* ImportedMediaGalleryRegistry::GetInstance() {

[commit-bot: I haz the power, 2013-06-07 14:21:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinuko@chromium.org/16466006/53001

[commit-bot: I haz the power, 2013-06-07 15:42:17]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[kinuko, 2013-06-10 03:09:16]

Committed patchset #6 manually as r205137 (presubmit successful).