Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Unified Diff: components/scheduler/renderer/web_view_scheduler_impl.h

Issue 1646583002: [Reland] Per WebViewScheduler virtual time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: WebViewSchedulerImpl to unregister the virtual_time_domain_ in the destructor Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/renderer/web_view_scheduler_impl.h
diff --git a/components/scheduler/renderer/web_view_scheduler_impl.h b/components/scheduler/renderer/web_view_scheduler_impl.h
index caed57ed8c5a8eb16ef2a3313e776248531f3bca..65aaeacf36940c3c4149f4a87646217afa5afdf5 100644
--- a/components/scheduler/renderer/web_view_scheduler_impl.h
+++ b/components/scheduler/renderer/web_view_scheduler_impl.h
@@ -23,6 +23,7 @@ class WebView;
namespace scheduler {
+class AutoAdvancingVirtualTimeDomain;
class RendererSchedulerImpl;
class WebFrameSchedulerImpl;
@@ -38,6 +39,9 @@ class SCHEDULER_EXPORT WebViewSchedulerImpl : public blink::WebViewScheduler {
void setPageVisible(bool page_visible) override;
blink::WebPassOwnPtr<blink::WebFrameScheduler> createFrameScheduler()
override;
+ void useVirtualTime() override;
Sami 2016/02/01 11:15:07 Now that this is WebView-specific, I guess it give
alex clarke (OOO till 29th) 2016/02/01 14:16:54 Quite a few :( One problem is the order in which
+ void setAllowVirtualTimeToAdvance(
+ bool allow_virtual_time_to_advance) override;
// Virtual for testing.
virtual void AddConsoleWarning(const std::string& message);
@@ -50,10 +54,12 @@ class SCHEDULER_EXPORT WebViewSchedulerImpl : public blink::WebViewScheduler {
void Unregister(WebFrameSchedulerImpl* frame_scheduler);
std::set<WebFrameSchedulerImpl*> frame_schedulers_;
+ scoped_ptr<AutoAdvancingVirtualTimeDomain> virtual_time_domain_;
blink::WebView* web_view_;
RendererSchedulerImpl* renderer_scheduler_;
bool page_visible_;
bool disable_background_timer_throttling_;
+ bool allow_virtual_time_to_advance_;
DISALLOW_COPY_AND_ASSIGN(WebViewSchedulerImpl);
};

Powered by Google App Engine
This is Rietveld 408576698