Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Side by Side Diff: components/scheduler/base/task_queue_manager.cc

Issue 1646583002: [Reland] Per WebViewScheduler virtual time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: WebViewSchedulerImpl to unregister the virtual_time_domain_ in the destructor Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/scheduler/base/task_queue_manager.h" 5 #include "components/scheduler/base/task_queue_manager.h"
6 6
7 #include <queue> 7 #include <queue>
8 #include <set> 8 #include <set>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 30 matching lines...) Expand all
41 : real_time_domain_(new RealTimeDomain()), 41 : real_time_domain_(new RealTimeDomain()),
42 delegate_(delegate), 42 delegate_(delegate),
43 task_was_run_on_quiescence_monitored_queue_(false), 43 task_was_run_on_quiescence_monitored_queue_(false),
44 work_batch_size_(1), 44 work_batch_size_(1),
45 task_count_(0), 45 task_count_(0),
46 tracing_category_(tracing_category), 46 tracing_category_(tracing_category),
47 disabled_by_default_tracing_category_( 47 disabled_by_default_tracing_category_(
48 disabled_by_default_tracing_category), 48 disabled_by_default_tracing_category),
49 disabled_by_default_verbose_tracing_category_( 49 disabled_by_default_verbose_tracing_category_(
50 disabled_by_default_verbose_tracing_category), 50 disabled_by_default_verbose_tracing_category),
51 current_selected_task_queue_(nullptr),
51 observer_(nullptr), 52 observer_(nullptr),
52 deletion_sentinel_(new DeletionSentinel()), 53 deletion_sentinel_(new DeletionSentinel()),
53 weak_factory_(this) { 54 weak_factory_(this) {
54 DCHECK(delegate->RunsTasksOnCurrentThread()); 55 DCHECK(delegate->RunsTasksOnCurrentThread());
55 TRACE_EVENT_OBJECT_CREATED_WITH_ID(disabled_by_default_tracing_category, 56 TRACE_EVENT_OBJECT_CREATED_WITH_ID(disabled_by_default_tracing_category,
56 "TaskQueueManager", this); 57 "TaskQueueManager", this);
57 selector_.SetTaskQueueSelectorObserver(this); 58 selector_.SetTaskQueueSelectorObserver(this);
58 59
59 from_main_thread_immediate_do_work_closure_ = 60 from_main_thread_immediate_do_work_closure_ =
60 base::Bind(&TaskQueueManager::DoWork, weak_factory_.GetWeakPtr(), 61 base::Bind(&TaskQueueManager::DoWork, weak_factory_.GetWeakPtr(),
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 212
212 // Only run a single task per batch in nested run loops so that we can 213 // Only run a single task per batch in nested run loops so that we can
213 // properly exit the nested loop when someone calls RunLoop::Quit(). 214 // properly exit the nested loop when someone calls RunLoop::Quit().
214 if (delegate_->IsNested()) 215 if (delegate_->IsNested())
215 break; 216 break;
216 } 217 }
217 218
218 // TODO(alexclarke): Consider refactoring the above loop to terminate only 219 // TODO(alexclarke): Consider refactoring the above loop to terminate only
219 // when there's no more work left to be done, rather than posting a 220 // when there's no more work left to be done, rather than posting a
220 // continuation task. 221 // continuation task.
221 if (!selector_.EnabledWorkQueuesEmpty() || TryAdvanceTimeDomains()) { 222 if (!selector_.EnabledWorkQueuesEmpty() || TryAdvanceTimeDomains())
222 MaybeScheduleImmediateWork(FROM_HERE); 223 MaybeScheduleImmediateWork(FROM_HERE);
223 } else {
224 // Tell the task runner we have no more work.
225 delegate_->OnNoMoreImmediateWork();
226 }
227 } 224 }
228 225
229 bool TaskQueueManager::TryAdvanceTimeDomains() { 226 bool TaskQueueManager::TryAdvanceTimeDomains() {
230 bool can_advance = false; 227 bool can_advance = false;
231 for (TimeDomain* time_domain : time_domains_) { 228 for (TimeDomain* time_domain : time_domains_) {
232 can_advance |= time_domain->MaybeAdvanceTime(); 229 can_advance |= time_domain->MaybeAdvanceTime();
233 } 230 }
234 return can_advance; 231 return can_advance;
235 } 232 }
236 233
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 270
274 TRACE_TASK_EXECUTION("TaskQueueManager::ProcessTaskFromWorkQueue", 271 TRACE_TASK_EXECUTION("TaskQueueManager::ProcessTaskFromWorkQueue",
275 pending_task); 272 pending_task);
276 if (queue->GetShouldNotifyObservers()) { 273 if (queue->GetShouldNotifyObservers()) {
277 FOR_EACH_OBSERVER(base::MessageLoop::TaskObserver, task_observers_, 274 FOR_EACH_OBSERVER(base::MessageLoop::TaskObserver, task_observers_,
278 WillProcessTask(pending_task)); 275 WillProcessTask(pending_task));
279 queue->NotifyWillProcessTask(pending_task); 276 queue->NotifyWillProcessTask(pending_task);
280 } 277 }
281 TRACE_EVENT1(tracing_category_, 278 TRACE_EVENT1(tracing_category_,
282 "TaskQueueManager::RunTask", "queue", queue->GetName()); 279 "TaskQueueManager::RunTask", "queue", queue->GetName());
280 internal::TaskQueueImpl* prev_selected_task_queue =
281 current_selected_task_queue_;
282 current_selected_task_queue_ = queue;
283 task_annotator_.RunTask("TaskQueueManager::PostTask", pending_task); 283 task_annotator_.RunTask("TaskQueueManager::PostTask", pending_task);
284 current_selected_task_queue_ = prev_selected_task_queue;
Sami 2016/02/01 11:15:06 Should we guard against prev_selected_task_queue g
alex clarke (OOO till 29th) 2016/02/01 14:16:54 Done.
284 285
285 // Detect if the TaskQueueManager just got deleted. If this happens we must 286 // Detect if the TaskQueueManager just got deleted. If this happens we must
286 // not access any member variables after this point. 287 // not access any member variables after this point.
287 if (protect->HasOneRef()) 288 if (protect->HasOneRef())
288 return ProcessTaskResult::TASK_QUEUE_MANAGER_DELETED; 289 return ProcessTaskResult::TASK_QUEUE_MANAGER_DELETED;
289 290
290 if (queue->GetShouldNotifyObservers()) { 291 if (queue->GetShouldNotifyObservers()) {
291 FOR_EACH_OBSERVER(base::MessageLoop::TaskObserver, task_observers_, 292 FOR_EACH_OBSERVER(base::MessageLoop::TaskObserver, task_observers_,
292 DidProcessTask(pending_task)); 293 DidProcessTask(pending_task));
293 queue->NotifyDidProcessTask(pending_task); 294 queue->NotifyDidProcessTask(pending_task);
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
399 internal::WorkQueue* work_queue) { 400 internal::WorkQueue* work_queue) {
400 DCHECK(main_thread_checker_.CalledOnValidThread()); 401 DCHECK(main_thread_checker_.CalledOnValidThread());
401 DCHECK(!work_queue->Empty()); 402 DCHECK(!work_queue->Empty());
402 if (observer_) { 403 if (observer_) {
403 observer_->OnTriedToExecuteBlockedTask(*work_queue->task_queue(), 404 observer_->OnTriedToExecuteBlockedTask(*work_queue->task_queue(),
404 *work_queue->GetFrontTask()); 405 *work_queue->GetFrontTask());
405 } 406 }
406 } 407 }
407 408
408 } // namespace scheduler 409 } // namespace scheduler
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698